-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Package gremlin.0.1.1 #14534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package gremlin.0.1.1 #14534
Conversation
|
You forgot to provide the url to the archive of your package (see the |
|
Also, could you avoid the |
packages/gremlin/gremlin.v0.1.1/opam
Outdated
| "conduit-lwt-unix" | ||
| "containers" | ||
| "core" | ||
| "dune" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "dune" | |
| "dune" {>= "1.10"} |
Your dune-project file in the source code says you require at least dune 1.10.
|
You have a lot of big dependencies with no constraints on their minimal version required. I suspect there are several needed here but if you don't have time to put them all it's ok. |
|
wait you had a whole lot of constraints in #14498, where did there all go? |
|
Also I'm not entirely sure why you removed this PR to create another one. It's more difficult to work with several PRs than with just one if you push over it. |
☀️ All lint checks passed 9f7c9e1
☀️ Installability check (+1)
|
|
Everything should be working now.
I've put them back in. I wasn't sure whether to specify the known working dependency versions or leave them blank and let others test/report. I've seen various packages from the community do it either way.
This was because github doesn't allow branch renaming in PRs as far as I could tell. I wanted the branch name to match the version number. |
|
Your package is again missing the |
Fixed. |
|
Thanks! |
gremlin.0.1.1Gremlin Client Library
This is an Apache Tinkerpop3 Gremlin client library.
See the official tinkerpop3 and gremlin docs:
This client library is implemented following the driver provider requirements:
🐫 Pull-request generated by opam-publish v2.0.0