Skip to content

Conversation

@bramford
Copy link
Contributor

gremlin.0.1.0

Gremlin Client Library
This is an Apache Tinkerpop3 Gremlin client library.

See the official tinkerpop3 and gremlin docs:

This client library is implemented following the driver provider requirements:



🐫 Pull-request generated by opam-publish v2.0.0

build: [ "dune" "build" "-j" jobs "-p" name ]
depends: [
"ocaml" {>= "4.07.1"}
"dune" {build & >= "1.10.0"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"dune" {build & >= "1.10.0"}
"dune" {>= "1.10.0"}

Dune should not be flagged as a build dependency anymore (see #14266)

"lwt_ppx" {>= "1.2.2"}
"conduit-lwt-unix" {>= "1.4.0"}
"yojson" {>= "1.7.0"}
"core" {>= "0.12.3"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"core" {>= "0.12.3"}
"core" {>= "v0.12.3"}

The v prefix for janestreet packages are relevant

"conduit-lwt-unix" {>= "1.4.0"}
"yojson" {>= "1.7.0"}
"core" {>= "0.12.3"}
"ppx_let" {>= "0.12.0"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"ppx_let" {>= "0.12.0"}
"ppx_let" {>= "v0.12.0"}

@camelus
Copy link
Contributor

camelus commented Jul 13, 2019

☀️ All lint checks passed 17544bc
  • These packages passed lint tests: gremlin.0.1.0

☀️ Installability check (+1)
  • new installable packages (1): gremlin.0.1.0

@kit-ty-kate
Copy link
Member

Also there is a missing dependency apparently:


#=== ERROR while compiling gremlin.0.1.0 ======================================#
# context              2.0.4 | linux/x86_64 | ocaml-base-compiler.4.08.0 | pinned(https://github.com/bramford/ocaml-gremlin/archive/v0.1.0.tar.gz)
# path                 ~/.opam/4.08/.opam-switch/build/gremlin.0.1.0
# command              ~/.opam/4.08/bin/dune build -j 2 -p gremlin
# exit-code            1
# env-file             ~/.opam/log/gremlin-15-4a7a12.env
# output-file          ~/.opam/log/gremlin-15-4a7a12.out
### output ###
# File "src/dune", line 7, characters 4-13:
# 7 |     websocket
#         ^^^^^^^^^
# Error: Library "websocket" not found.
# Hint: try: dune external-lib-deps --missing -j 2 -p gremlin @@default

@bramford bramford changed the title Package gremlin.0.1.0 Package gremlin.v0.1.1 Jul 17, 2019
@bramford bramford changed the title Package gremlin.v0.1.1 Package gremlin.0.1.0 Jul 17, 2019
@bramford bramford closed this Jul 17, 2019
@bramford bramford deleted the opam-publish-gremlin.0.1.0 branch July 17, 2019 12:03
@bramford
Copy link
Contributor Author

I've fixed the issues and opened #14534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants