Skip to content

Fix compile error for no std #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristopherRabotin merged 2 commits into from
Jul 27, 2025
Merged

Fix compile error for no std #408

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27c513a
no cdylib for no std
ephraim71 Jul 27, 2025
da78dc2
add comment for cdylib in std
ephraim71 Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,14 @@ exclude = ["*.tar.gz", "data/"]
edition = "2021"

[lib]
crate-type = ["cdylib", "rlib"]
crate-type = ["rlib"]
name = "hifitime"

# `cdylib` is useful only when the `std` feature is on.
# In `no_std`, dynamic‑link targets face “unwinding panics not supported” https://github.com/nyx-space/hifitime/issues/343
[target.'cfg(feature = "std")'.lib]
crate-type = ["cdylib", "rlib"]
Comment on lines +22 to +23
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jul 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding a comment to explain why cdylib is only built with the std feature would improve long-term maintainability and clarify the intent for future contributors.

# The `cdylib` crate type is only supported with the `std` feature.
[target.'cfg(feature = "std")'.lib]

Copy link
Contributor Author

@ephraim71 ephraim71 Jul 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comment


[package.metadata.docs.rs]
all-features = true
rustdoc-args = ["--cfg", "docrs", "--generate-link-to-definition"]
Expand Down
Loading