-
-
Notifications
You must be signed in to change notification settings - Fork 31
Fix compile error for no std #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compile error for no std #408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ephraim71, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a compilation error that occurs when the library is built in a no_std environment. The core change involves adjusting the build configuration in Cargo.toml to conditionally enable the cdylib crate type only when the std feature is active, thereby preventing cdylib from being built in contexts where the standard library is not present.
Highlights
- Build Configuration: Modified the
Cargo.tomlfile to make thecdylib(C dynamic library) crate type conditional on thestdfeature. This change ensures that the C dynamic library is only built when the standard library is available, specifically addressing and resolving potential compilation errors inno_stdenvironments.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a compilation error for no_std builds by conditionally enabling the cdylib crate type based on the std feature. A comment has been suggested to improve the maintainability of this configuration.
| [target.'cfg(feature = "std")'.lib] | ||
| crate-type = ["cdylib", "rlib"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added comment
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #408 +/- ##
==========================================
- Coverage 83.87% 82.64% -1.23%
==========================================
Files 24 24
Lines 3813 3566 -247
==========================================
- Hits 3198 2947 -251
- Misses 615 619 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks good, thanks @ephraim71! |
From :
#343
no_std already works for these :
cargo build --target aarch64-unknown-none --no-default-featurescargo build --target thumbv6m-none-eabi --no-default-featuresTo use no_std without having to cross compile, cdylib has to be excluded.