Skip to content

Adding download code for ARCT, MCTest, MCTACO, MuTual, and QuAIL#1258

Merged
jeswan merged 11 commits intomasterfrom
cv-tasks-downloader
Jan 7, 2021
Merged

Adding download code for ARCT, MCTest, MCTACO, MuTual, and QuAIL#1258
jeswan merged 11 commits intomasterfrom
cv-tasks-downloader

Conversation

@claravania
Copy link
Collaborator

@claravania claravania commented Jan 5, 2021

This PR adds download code for the following tasks: arct, mctest160, mctest600, mctaco, mutual, mutual_plus, and quail. Besides quail which uses HF datasets, all tasks use direct download links.

Tested using the following command:

export PYTHONPATH=jiant/
python jiant/jiant/scripts/download_data/runscript.py download --tasks [TASK_NAME] --output_path [OUTPUT_PATH]

Copy link
Collaborator

@jeswan jeswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One concern about QuAIL (see comment). Will approve after this concern and formatting is addressed.

claravania and others added 2 commits January 5, 2021 16:00
Co-authored-by: jeswan <57466294+jeswan@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #1258 (a3cfd5b) into master (9a45712) will decrease coverage by 0.34%.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1258      +/-   ##
==========================================
- Coverage   55.86%   55.51%   -0.35%     
==========================================
  Files         149      149              
  Lines       10825    10903      +78     
==========================================
+ Hits         6047     6053       +6     
- Misses       4778     4850      +72     
Impacted Files Coverage Δ
jiant/scripts/download_data/constants.py 100.00% <ø> (ø)
...pts/download_data/dl_datasets/hf_datasets_tasks.py 100.00% <ø> (ø)
jiant/tasks/lib/quail.py 77.77% <ø> (ø)
...t/scripts/download_data/dl_datasets/files_tasks.py 7.56% <7.69%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a45712...a3cfd5b. Read the comment docs.

@claravania
Copy link
Collaborator Author

@jeswan I've fixed the QuAIL and reformat issues.

@claravania claravania requested a review from jeswan January 6, 2021 17:41
@jeswan jeswan merged commit e9d6c68 into master Jan 7, 2021
@jeswan jeswan deleted the cv-tasks-downloader branch January 7, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants