Change wording of delete profile confirmation #6884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsteh
approved these changes
Feb 14, 2017
source/gui/configProfiles.py
Outdated
| if gui.messageBox( | ||
| # Translators: The confirmation prompt displayed when the user requests to delete a configuration profile. | ||
| _("Are you sure you want to delete this profile? This cannot be undone."), | ||
| _("This profile will be permanently deleted, this action cannot be undone."), |
Contributor
There was a problem hiding this comment.
Please split this into two sentences; i.e. "This profile will be permanently deleted. This action cannot be undone."
feerrenrut
added a commit
that referenced
this pull request
Feb 14, 2017
feerrenrut
added a commit
that referenced
this pull request
Mar 14, 2017
For PR #6761 - Web page menu items (menu item checkbox's and radio buttons) can now be activated while in browse mode. Issue #6735 For PR #6866 - Excel sheet name reporting is now translated. Issue #6848 For PR #6884 - Pressing ESC while the configuration profile "Confirm Deletion" prompt is active now dismisses the dialog. Issue #6851 For PR #6895 - Cell border information can now be reported in Microsoft Excel by using `NVDA+f`. Issue #3044 For PR #6860 - Added support for aria-current attributes. Issue #6358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing escape does not exit the "confirm profile deletion" dialog. To fix this the dialog has been reworded and the buttons changed to
ok | cancelFixes #6851
The wx docs for messageBox specifies:
Adding
wx.CANCELallows the dialog to be dismissed with theesckey. However, addingwx.CANCELresults in three buttons (yes, no, and cancel). Rather than do that I have re-worded the sentence, swapped to use the ok/cancel buttons. The message box will now say: