Activating menu items on webpages in browse mode #6761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for #6735 Menu items (as well as menu item checkbox and menu item radio) can be now be activated while in browse mode.
jcsteh
approved these changes
Jan 20, 2017
source/browseMode.py
Outdated
| def _get_currentNVDAObject(self): | ||
| raise NotImplementedError | ||
|
|
||
| ALWAYS_SWITCH_TO_PASS_THROUGH_ROLES = ( |
Contributor
There was a problem hiding this comment.
Please make this a set (or a frozenset if you want it to be immutable) rather than a tuple. That makes checking membership a hash lookup instead of O(n) and this is not just a few elements. I realise it was a tuple before it was a constant. :)
source/browseMode.py
Outdated
| controlTypes.ROLE_TABLEROW, | ||
| controlTypes.ROLE_TABLECELL, | ||
| controlTypes.ROLE_TABLEROWHEADER, | ||
| controlTypes.ROLE_TABLECOLUMNHEADER) |
Contributor
There was a problem hiding this comment.
Convention for long collections is to treat the last item like every other item and put the closing parenthesis on its own line. So:
controlTypes.ROLE_TABLECOLUMNHEADER,
)
(The trailing comma is not a mistake.)
This means that adding a new entry at the bottom just adds a new line, rather than changing an unrelated line as well. For more on this, see this Python FAQ and this StackOverflow thread.
source/browseMode.py
Outdated
| controlTypes.ROLE_TABLEROWHEADER, | ||
| controlTypes.ROLE_TABLECOLUMNHEADER) | ||
|
|
||
| SWITCH_TO_PASS_THROUGH_ON_FOCUS_ROLES = ( |
feerrenrut
added a commit
that referenced
this pull request
Feb 1, 2017
feerrenrut
added a commit
that referenced
this pull request
Mar 14, 2017
For PR #6761 - Web page menu items (menu item checkbox's and radio buttons) can now be activated while in browse mode. Issue #6735 For PR #6866 - Excel sheet name reporting is now translated. Issue #6848 For PR #6884 - Pressing ESC while the configuration profile "Confirm Deletion" prompt is active now dismisses the dialog. Issue #6851 For PR #6895 - Cell border information can now be reported in Microsoft Excel by using `NVDA+f`. Issue #3044 For PR #6860 - Added support for aria-current attributes. Issue #6358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #6735
Menu items (as well as menu item checkbox and menu item radio) can be
now be activated while in browse mode.