Skip to content
This repository was archived by the owner on Jan 20, 2022. It is now read-only.

Conversation

@mikemimik
Copy link

What / Why

Expose the tree diff Diff node, in order for the cli to be able to print the results of an arborist action.

References

@mikemimik mikemimik added the semver:minor new backwards-compatible feature label Mar 12, 2020
@mikemimik mikemimik added this to the OSS - Sprint 6 milestone Mar 12, 2020
@mikemimik mikemimik self-assigned this Mar 12, 2020
@mikemimik mikemimik requested review from a team and isaacs March 12, 2020 19:13
@mikemimik mikemimik force-pushed the mikemimik/feature/expose-diff branch from 244db1e to 0eb2b1b Compare March 13, 2020 04:47
Copy link
Contributor

@isaacs isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two extremely tiny nits. Otherwise LGTM.

- removed addition of explicit 'save' option value default
- added type equality check to exposed to property
@mikemimik mikemimik merged commit ef12880 into master Mar 18, 2020
@ruyadorno ruyadorno deleted the mikemimik/feature/expose-diff branch May 25, 2020 14:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

semver:minor new backwards-compatible feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants