Skip to content
This repository was archived by the owner on Jan 20, 2022. It is now read-only.

Commit ef12880

Browse files
Michael Perrottemikemimik
authored andcommitted
fix: address pull-request feedback
- removed addition of explicit 'save' option value default - added type equality check to exposed to property
1 parent b2262b1 commit ef12880

2 files changed

Lines changed: 1 addition & 1 deletion

File tree

lib/arborist/reify.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ module.exports = cls => class Reifier extends Ideal(cls) {
9898
scriptShell,
9999
savePrefix = '^',
100100
binLinks = true,
101-
save = true,
102101
} = options
103102

104103
if (!binLinks)

test/arborist/build-ideal-tree.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,7 @@ t.test('expose explicitRequest', async t => {
210210
const arb = new Arborist({ path })
211211
const tree = await arb.buildIdealTree({ add: [ 'abbrev' ] })
212212
t.ok(arb.explicitRequests, 'exposes the explicit request')
213+
t.strictSame(arb.explicitRequests, new Set(['abbrev']))
213214
t.ok(arb.explicitRequests.has('abbrev'), 'should contain explicit item')
214215
t.end()
215216
})

0 commit comments

Comments
 (0)