Skip to content

test: ensure assertions are reached on more tests #60485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2025
Merged

test: ensure assertions are reached on more tests #60485

merged 1 commit into from
Nov 6, 2025
+258 −296

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 29, 2025

Another follow up of #60125

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 29, 2025
@codecov
Copy link

codecov bot commented Oct 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.57%. Comparing base (761d4f4) to head (e72761f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60485      +/-   ##
==========================================
+ Coverage   88.54%   88.57%   +0.03%     
==========================================
  Files         704      704              
  Lines      208087   208087              
  Branches    40082    40090       +8     
==========================================
+ Hits       184242   184306      +64     
+ Misses      15877    15849      -28     
+ Partials     7968     7932      -36

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 30, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 30, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69958/

This was referenced Oct 30, 2025
Merged
Merged
@aduh95 aduh95 force-pushed the must-call-mustCalls branch from cd017a2 to e72761f Compare November 6, 2025 08:47
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 6, 2025

Landed in e72761f

@aduh95 aduh95 merged commit e72761f into nodejs:main Nov 6, 2025
20 of 21 checks passed
aduh95 added a commit that referenced this pull request Nov 10, 2025
@aduh95
test: ensure assertions are reached on more tests
6aaf18c 
PR-URL: #60485
Reviewed-By: Colin Ihrig <[email protected]>
@github-actions github-actions bot mentioned this pull request Nov 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aduh95 @nodejs-github-bot @cjihrig