src: move Node-API version detection to where it is used #60512
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`src/js_native_api_types.h` and other files actually depend on the moved macros being evaluated, so before this change there was an implicit requirement that `src/js_native_api.h` would be included separately before any include of `src/js_native_api_types.h`, direct or transitive.
This means that `node.h` can include only this file, instead of the entirety of `node_api.h`. Split out from nodejs#60496 since it was rightfully pointed out that the breaking part of the change should not touch Node-API headers.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
addaleax
added
the
commit-queue-rebase
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60512 +/- ##
=======================================
Coverage 88.56% 88.56%
=======================================
Files 704 704
Lines 207858 207858
Branches 40058 40053 -5
=======================================
Hits 184089 184089
+ Misses 15807 15803 -4
- Partials 7962 7966 +4 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Oct 31, 2025
addaleax
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
cjihrig
approved these changes
Nov 1, 2025
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 8f66bec...85ee01c |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 2, 2025
`src/js_native_api_types.h` and other files actually depend on the moved macros being evaluated, so before this change there was an implicit requirement that `src/js_native_api.h` would be included separately before any include of `src/js_native_api_types.h`, direct or transitive. PR-URL: #60512 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 2, 2025
This means that `node.h` can include only this file, instead of the entirety of `node_api.h`. Split out from #60496 since it was rightfully pointed out that the breaking part of the change should not touch Node-API headers. PR-URL: #60512 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
github-project-automation
bot
moved this from Need Triage
to Done
in Node-API Team Project
aduh95
pushed a commit
that referenced
this pull request
Nov 5, 2025
`src/js_native_api_types.h` and other files actually depend on the moved macros being evaluated, so before this change there was an implicit requirement that `src/js_native_api.h` would be included separately before any include of `src/js_native_api_types.h`, direct or transitive. PR-URL: #60512 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Nov 5, 2025
This means that `node.h` can include only this file, instead of the entirety of `node_api.h`. Split out from #60496 since it was rightfully pointed out that the breaking part of the change should not touch Node-API headers. PR-URL: #60512 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src: move Node-API version detection to where it is used
src/js_native_api_types.hand other files actually depend onthe moved macros being evaluated, so before this change there
was an implicit requirement that
src/js_native_api.hwould beincluded separately before any include of
src/js_native_api_types.h, direct or transitive.src: move
napi_addon_register_functonode_api_types.hThis means that
node.hcan include only this file, instead ofthe entirety of
node_api.h.Split out from #60496 since
it was rightfully pointed out that the breaking part of the change
should not touch Node-API headers.