Skip to content

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented Aug 27, 2021

Fix the VersionSelector rule for ubuntu2004 to allow for the arch
qualifier (e.g. arm).

Refs: #2731

Fix the VersionSelector rule for ubuntu2004 to allow for the arch
qualifier (e.g. arm).
@richardlau
Copy link
Member Author

This is a test build against Node.js 12 after landing #2731 which shows the exclusion not working: https://ci.nodejs.org/job/node-test-commit-arm/38772/console

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the fix! I guess since we don't have any other architectures running 20.04 just now this will be ok but we'll need to be aware of it if we were to add, say, ppc64le or s390x Ubuntu 20.04 images in the future (or just avoid doing so until 12 goes out of support!)

@richardlau richardlau merged commit 3f5e988 into nodejs:master Aug 27, 2021
@richardlau richardlau deleted the versionselector branch August 27, 2021 16:16
@richardlau
Copy link
Member Author

https://ci.nodejs.org/job/node-test-commit-arm/38773/console

17:16:28 Node.js version: 12.22.6
17:16:28 Skipping centos7-arm64-gcc8 for Node.js 12
17:16:28 Skipping ubuntu2004-arm64 for Node.js 12

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants