ansible: add first equinix Altra as docker host #2731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
reviewed
Aug 24, 2021
Signed-off-by: Stewart X Addison <[email protected]>
sxa
force-pushed
the
ubuntu2004_dockerhost
branch
from
c94bfa1 to
a2623fc
Compare
Signed-off-by: Stewart X Addison <[email protected]>
sxa
force-pushed
the
ubuntu2004_dockerhost
branch
from
621ea50 to
267994d
Compare
AshCripps
approved these changes
Aug 25, 2021
richardlau
reviewed
Aug 25, 2021
ansible/roles/docker/templates/ubuntu2004_sharedlibs.Dockerfile.j2
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard Lau <[email protected]>
…e.j2 Co-authored-by: Richard Lau <[email protected]>
richardlau
approved these changes
Aug 26, 2021
rvagg
reviewed
Aug 27, 2021
Member
|
The new labels were added to node-test-commit-arm which has meant that the Node.js 12 builds now fail without the VersionSelector changes in this PR, e.g. https://ci.nodejs.org/job/node-test-commit-arm/nodes=ubuntu2004-arm64/38770/console I think we can land this and iterate updates. |
Member
Author
Would be nice to land it (given that it doesn't appear to impact the test runs if the architecture is incorrect) but give me another half an hour to work on the templating before a final decision |
richardlau
reviewed
Aug 27, 2021
sxa
force-pushed
the
ubuntu2004_dockerhost
branch
from
250c947 to
ec84644
Compare
richardlau
reviewed
Aug 27, 2021
AshCripps
approved these changes
Aug 27, 2021
Member
AshCripps
left a comment
AshCripps
left a comment
There was a problem hiding this comment.
LGTM once @richardlau's comment is addressed
Signed-off-by: Stewart X Addison <[email protected]>
sxa
force-pushed
the
ubuntu2004_dockerhost
branch
from
ec84644 to
5670d5e
Compare
richardlau
approved these changes
Aug 27, 2021
richardlau
added a commit
that referenced
this pull request
Aug 27, 2021
Fix the VersionSelector rule for ubuntu2004 to allow for the arch qualifier (e.g. arm). Refs: #2731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defines the first of the Ampere Altra systems (160 core, loads of RAM) as a docker host which can be used for building and testing.
This is in draft as it will need another change for the docker package, which may need to be changed to
docker.ioinstead of the standalonedocker-cepackage on Ubuntu 20.04.Part of #2729
Signed-off-by: Stewart X Addison [email protected]