Fix for raw inflate with directory #156
Merged
+43
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puzrin
requested changes
Jan 9, 2019
puzrin
approved these changes
Jan 9, 2019
Member
|
LGTM. See minor comments about tests. Since this part of code is touched, it would be nice to clean related things. But if you a busy, i can merge as is and do the rest myself. Let me know. |
Contributor
Author
|
In susequent commits I have removed the |
Contributor
Author
|
@puzrin ping? |
Contributor
Author
|
Thank you, I appreciate your good work! |
Member
|
Published new release with your fixes. Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155
inflateSetDictionary()is called at different conditions during normal and raw modes, according to http://zlib.net/manual.html#AdvancedAlso providing basic tests for raw inflate with directory, and fix for broken test Inflate with dictionary/spdy dictionary