Allow raw inflation with a custom dictionary. #120
Closed
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just roughly tested, but I just ported the change from nodejs/node#8512, or at least attempted to. Before, when trying to inflateRaw (or inflate({raw:true});) with a custom dictionary, you would get 'invalid distance too far back'. This no longer seems to happen, so I think I fixed it.
easyaspi314
changed the title
Even more annoying than accidental tabs.
Member
|
Looks ok, but could you add test (copy-paste existing one for non-raw deflate)? |
|
@easyaspi314 how about a test for your PR? I don't think this PR will be merged if there are no tests... |
Member
|
Close in favor of #156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just roughly tested, but I just ported the
change from nodejs/node#8512, or at least attempted to.
Before, when trying to inflateRaw (or inflate({raw:true});) with a custom
dictionary, you would get 'invalid distance too far back'.
This no longer seems to happen, so I think I fixed it.
I wasn't able to get browserify working, but I successfully tested it in the REPL.
Feel free to reformat or move things if necessary. I won't call myself the best at following code style.