Skip to content

[Mellanox] Add a query in MDF to make copper-active modules be FW control#61

Closed
noaOrMlnx wants to merge 3 commits intomasterfrom
mellanox-sw-control-fix
Closed

[Mellanox] Add a query in MDF to make copper-active modules be FW control#61
noaOrMlnx wants to merge 3 commits intomasterfrom
mellanox-sw-control-fix

Conversation

@noaOrMlnx
Copy link
Copy Markdown
Owner

Why I did it

Nvidia doesn't support Copper Active modules to be SW control.
In case we use this kind of module, it should be classified as FW control.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Checked the media interface technology for the module. If it is Copper cable, linear active equalizers, it should be classified as FW control.

How to verify it

Run this code on Mellanox switch with Copper cable, linear active equalizers module. check control sysfs to make sure it is classified as FW control. (control = 0).

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

202412

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@noaOrMlnx noaOrMlnx force-pushed the mellanox-sw-control-fix branch from b673067 to ccf5169 Compare May 7, 2025 11:24
Copy link
Copy Markdown
Collaborator

@Junchao-Mellanox Junchao-Mellanox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does UT pass after this change?

@noaOrMlnx
Copy link
Copy Markdown
Owner Author

Does UT pass after this change?

@Junchao-Mellanox Yes - CI passed the build.
UT will only check if it's xcvr api, but it won't inject the active copper to media interface technology. so it should be SW control.

noaOrMlnx pushed a commit that referenced this pull request May 14, 2025
…ly (sonic-net#22572)

#### Why I did it
src/sonic-stp
```
* cc80f49 - (HEAD -> master, origin/master, origin/HEAD) MSTP configuration handling APIs (#61) (18 hours ago) [Divya Kumaran Chandralekha]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elif? and how about else?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@noaOrMlnx noaOrMlnx force-pushed the mellanox-sw-control-fix branch from 6ee45e9 to 321de88 Compare May 21, 2025 06:41
@noaOrMlnx noaOrMlnx force-pushed the mellanox-sw-control-fix branch from da6b121 to 0d50067 Compare May 22, 2025 07:26
@noaOrMlnx noaOrMlnx closed this Jun 8, 2025
noaOrMlnx pushed a commit that referenced this pull request Oct 26, 2025
…lly (sonic-net#896)

#### Why I did it
src/sonic-swss
```
* 16cc0f6 - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-swss:202411 to 202412 (#61) (20 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
noaOrMlnx pushed a commit that referenced this pull request Oct 26, 2025
…D automatically (sonic-net#1214)

#### Why I did it
src/sonic-sairedis
```
* f21e12c - (HEAD -> 202412, origin/HEAD, origin/202412) [trim]: Add Packet Trimming Port/Queue stats to VS lib (#60) (8 hours ago) [Nazarii Hnydyn]
* 9d39644 - Merge pull request #61 from mssonicbld/cherry/msft-202412/1548 (4 days ago) [Ze Gan]
* 613654b - [syncd] Move log set function after api initialize (4 days ago) [Sonic Build Admin]
```
#### How I did it
#### How to verify it
#### Description for the changelog
noaOrMlnx pushed a commit that referenced this pull request Oct 26, 2025
…HEAD automatically (sonic-net#1599)

#### Why I did it
src/sonic-swss-common
```
* 66ac80e - (HEAD -> 202412, origin/HEAD, origin/202412) Add c-api/Rust wrappers for ConfigDBConnector and EventPublisher (#66) (13 hours ago) [mssonicbld]
* 9e5b094 - Add test case to verify zmq reconnect behaviour (#63) (17 hours ago) [mssonicbld]
* b4a3cc6 - Ignore nonexistent include in database_global.json (#64) (17 hours ago) [mssonicbld]
* 4f576db - Move SonicDbTable to sonic-dash-ha. (#65) (17 hours ago) [mssonicbld]
* fd28e9d - Move swss-common/swss-common-testing crates from https://github.com/sonic-net/sonic-dash-ha (#62) (17 hours ago) [mssonicbld]
* 726586c - SWSSDBConnector_new_keyed to c-api (#61) (19 hours ago) [mssonicbld]
* 16a2234 - c-api: README.md (#60) (19 hours ago) [mssonicbld]
* b501364 - Add swss::Logger to c-api (#59) (23 hours ago) [mssonicbld]
* c51425c - C API Exceptions (#58) (24 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
noaOrMlnx pushed a commit that referenced this pull request Oct 26, 2025
…tomatically (sonic-net#1600)

#### Why I did it
src/sonic-gnmi
```
*   64e8539 - (HEAD -> 202412, origin/202412) Merge pull request sonic-net#97 from Azure/202412-dev (4 hours ago) [Zain Budhwani]
|\  
| * 0de6456 - Adapt to the new usages of arguments (sonic-net#93) (6 hours ago) [Changrong Wu]
| * 0be3a77 - Remove redundant helper function toString from show_common.go (sonic-net#86) (23 hours ago) [gnemuw]
| * ff54cad - Fetch arguments from path and supply getters with parsed arguments (sonic-net#82) (25 hours ago) [Zain Budhwani]
| * 14660a2 - Add `show dropcounters config` (sonic-net#79) (33 hours ago) [Changrong Wu]
| * 1b7b835 - Added telemetry support for the 'show queue watermark' command. (#72) (5 days ago) [mramezani95]
| * 417ebe5 - interaces description implementation (#69) (6 days ago) [Vijay Sharma]
| * d3140d8 - Implement 'show ipv6 route' command (#64) (6 days ago) [gnemuw]
| * a715f58 - Add show services (#74) (7 days ago) [Zhaoyang Zhang]
| * fe4ab1c - Fix the show headroom_pool typo (sonic-net#76) (7 days ago) [Guoqiang Yuan]
| * 0277718 - Add show interface naming_mode (#73) (7 days ago) [axin]
| * 03519fe - Add show interface neighbor expected (#54) (7 days ago) [jiayuj2021]
| * f29223a - Add 'show ipv6 fib' command (#67) (7 days ago) [Guoqiang Yuan]
| * 8ae677e - Add SHOW implementation for processes (#63) (8 days ago) [yiliu4]
| * 61927f9 - [202412] Add support of 'show ipv6 link-local-mode' command (#65) (8 days ago) [cgangx]
| * 4dca30c - Add show interface flap support (#66) (8 days ago) [axin]
| * 18c276b - Add show system memory (#57) (8 days ago) [Changrong Wu]
| * 00cc010 - Add support for show interface status (#32) (8 days ago) [Changrong Wu]
| * 941b3a2 - Minor changes from VLAN Brief PR Comments (#68) (8 days ago) [Vijay Sharma]
| * af89dec - show uptime (#39) (9 days ago) [Vijay Sharma]
| * 718ffd7 - Add show ipv6 bgp network (#61) (9 days ago) [Zhaoyang Zhang]
| * 8346e29 - [202412] Add support for 'show ipv6 bgp neighbors (#58) (9 days ago) [zitingguo-ms]
| * aec577c - Add implementation for show lldp neighbors (#56) (10 days ago) [nanali-msft]
| * b561228 - Add show dropcounters counts / capabilities (#40) (13 days ago) [jiayuj2021]
| * 16d6ccc - Add support for dev branches in CodeQL analysis (13 days ago) [Zain Budhwani]
* 8e41780 - Revert "Sync 202412 dev with 202412 (sonic-net#94)" (sonic-net#96) (4 hours ago) [Zain Budhwani]
* c5b5383 - Sync 202412 dev with 202412 (sonic-net#94) (5 hours ago) [Zain Budhwani]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants