Update buffer calculations for SN56xx to include service ports#60
Closed
Update buffer calculations for SN56xx to include service ports#60
Conversation
noaOrMlnx
force-pushed
the
mellanox-spc4-buffer-update
branch
from
11519a3 to
0b05195
Compare
noaOrMlnx
force-pushed
the
mellanox-spc4-buffer-update
branch
from
0b05195 to
38ef3c6
Compare
stephenxs
approved these changes
Apr 10, 2025
Collaborator
stephenxs
left a comment
stephenxs
left a comment
There was a problem hiding this comment.
LGTM if we want to reserve 1 service port on 5600 and 2 service ports on 5610.
Owner
Author
Yes, that's the plan. thanks |
noaOrMlnx
pushed a commit
that referenced
this pull request
Apr 24, 2025
…ly (sonic-net#22398) #### Why I did it src/sonic-stp ``` * 652adb6 - (HEAD -> master, origin/master, origin/HEAD) MSTP configuration handling APIs (#60) (20 hours ago) [Divya Kumaran Chandralekha] ``` #### How I did it #### How to verify it #### Description for the changelog
noaOrMlnx
pushed a commit
that referenced
this pull request
Jul 2, 2025
…ically (sonic-net#22841) #### Why I did it src/sonic-dash-ha ``` * 08aa5dc - (HEAD -> master, origin/master, origin/HEAD) Add "show hamgrd actor" CLI (#60) (28 hours ago) [yue-fred-gao] ``` #### How I did it #### How to verify it #### Description for the changelog
noaOrMlnx
pushed a commit
that referenced
this pull request
Oct 26, 2025
… automatically (sonic-net#842) #### Why I did it src/sonic-platform-common ``` * fed63a9 - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-platform-common:202411 to 202412 (#60) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
noaOrMlnx
pushed a commit
that referenced
this pull request
Oct 26, 2025
…lly (sonic-net#885) #### Why I did it src/sonic-swss ``` * 6c43afa - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-swss:202411 to 202412 (#60) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
noaOrMlnx
pushed a commit
that referenced
this pull request
Oct 26, 2025
…D automatically (sonic-net#1214) #### Why I did it src/sonic-sairedis ``` * f21e12c - (HEAD -> 202412, origin/HEAD, origin/202412) [trim]: Add Packet Trimming Port/Queue stats to VS lib (#60) (8 hours ago) [Nazarii Hnydyn] * 9d39644 - Merge pull request #61 from mssonicbld/cherry/msft-202412/1548 (4 days ago) [Ze Gan] * 613654b - [syncd] Move log set function after api initialize (4 days ago) [Sonic Build Admin] ``` #### How I did it #### How to verify it #### Description for the changelog
noaOrMlnx
pushed a commit
that referenced
this pull request
Oct 26, 2025
…HEAD automatically (sonic-net#1599) #### Why I did it src/sonic-swss-common ``` * 66ac80e - (HEAD -> 202412, origin/HEAD, origin/202412) Add c-api/Rust wrappers for ConfigDBConnector and EventPublisher (#66) (13 hours ago) [mssonicbld] * 9e5b094 - Add test case to verify zmq reconnect behaviour (#63) (17 hours ago) [mssonicbld] * b4a3cc6 - Ignore nonexistent include in database_global.json (#64) (17 hours ago) [mssonicbld] * 4f576db - Move SonicDbTable to sonic-dash-ha. (#65) (17 hours ago) [mssonicbld] * fd28e9d - Move swss-common/swss-common-testing crates from https://github.com/sonic-net/sonic-dash-ha (#62) (17 hours ago) [mssonicbld] * 726586c - SWSSDBConnector_new_keyed to c-api (#61) (19 hours ago) [mssonicbld] * 16a2234 - c-api: README.md (#60) (19 hours ago) [mssonicbld] * b501364 - Add swss::Logger to c-api (#59) (23 hours ago) [mssonicbld] * c51425c - C API Exceptions (#58) (24 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
To include service ports in buffer calculation
How I did it
Update buffer_defualts_t0/t1.j2 and included service ports in downlinks.
How to verify it
Run test_qos on a switch with the changes
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)