Skip to content

[Mellanox] Add SPC5 SN5640 platform, Mellanox-SN5640-C512S2,Mellanox-SN5640-C448O16 SKUs#47

Closed
noaOrMlnx wants to merge 12 commits intomasterfrom
Mellanox-SN5640-platform
Closed

[Mellanox] Add SPC5 SN5640 platform, Mellanox-SN5640-C512S2,Mellanox-SN5640-C448O16 SKUs#47
noaOrMlnx wants to merge 12 commits intomasterfrom
Mellanox-SN5640-platform

Conversation

@noaOrMlnx
Copy link
Owner

@noaOrMlnx noaOrMlnx commented Jan 12, 2025 •
edited
Loading

Add Mellanox SPC5 SN5640 platform, Mellanox-SN5640-C512S2 and Mellanox-SN5640-C448O16 SKUs

Why I did it

To support new Mellanox platform and SKUs

Work item tracking
  • Microsoft ADO (number only):

How I did it

Add and modified relevant files to support new platform and SKUs

How to verify it

Install supporting image on SN5640 Mellanox switch, deploy one of the SKUs

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@noaOrMlnx noaOrMlnx force-pushed the Mellanox-SN5640-platform branch from b71cc11 to 95bc7c5 Compare January 12, 2025 09:09
DavidZagury
DavidZagury requested changes Jan 12, 2025
View reviewed changes
@noaOrMlnx noaOrMlnx force-pushed the Mellanox-SN5640-platform branch from 95bc7c5 to 3db5a93 Compare January 12, 2025 14:02
@noaOrMlnx noaOrMlnx changed the base branch from master to noaor_copp_rpc_build January 12, 2025 14:04
@noaOrMlnx noaOrMlnx changed the base branch from noaor_copp_rpc_build to master January 12, 2025 14:04
@noaOrMlnx noaOrMlnx force-pushed the Mellanox-SN5640-platform branch from 3db5a93 to dfd87e8 Compare January 12, 2025 14:45
dprital
dprital reviewed Jan 12, 2025
View reviewed changes
@noaOrMlnx noaOrMlnx force-pushed the Mellanox-SN5640-platform branch 2 times, most recently from fdfca0d to cfc5521 Compare January 13, 2025 13:40
@noaOrMlnx noaOrMlnx force-pushed the Mellanox-SN5640-platform branch from cfc5521 to f50a9f3 Compare January 14, 2025 10:46
@noaOrMlnx
Copy link
Owner Author

noaOrMlnx commented Jan 14, 2025

@DavidZagury @dprital all comments were addressed.

@noaOrMlnx noaOrMlnx changed the title [Mellanox] Add SPC5 SN5640 platform, Mellanox-SN5640-C512S2 SKU [Mellanox] Add SPC5 SN5640 platform, Mellanox-SN5640-C512S2,Mellanox-SN5640-C448O16 SKUs Jan 15, 2025
DavidZagury
DavidZagury reviewed Jan 15, 2025
View reviewed changes
stephenxs
stephenxs reviewed Jan 16, 2025
View reviewed changes
@noaOrMlnx
Copy link
Owner Author

noaOrMlnx commented Jan 16, 2025

@stephenxs all comments were addressed. thanks for the review

stephenxs
stephenxs reviewed Jan 17, 2025
View reviewed changes
device/mellanox/x86_64-nvidia_sn5640-r0/Mellanox-SN5640-C512S2/buffers_defaults_t1.j2 Outdated
-%}
{% set ingress_lossless_pool_size = '105420800' %}
{% set ingress_lossless_pool_xoff = '0' %}
{% set egress_lossless_pool_size = '136210432' %}
Copy link
Collaborator

@stephenxs stephenxs Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does this number come from? I see the maximum pool is 709427 cells which is 136209984 bytes

device/mellanox/x86_64-nvidia_sn5640-r0/Mellanox-SN5640-C512S2/buffers_defaults_t1.j2 Outdated
'spinerouter_leafrouter' : '0m'
}
-%}
{% set ingress_lossless_pool_size = '105420800' %}
Copy link
Collaborator

@stephenxs stephenxs Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got 105419776

device/mellanox/x86_64-nvidia_sn5640-r0/Mellanox-SN5640-C448O16/buffers_defaults_t0.j2 Outdated
'spinerouter_leafrouter' : '0m'
}
-%}
{% set ingress_lossless_pool_size = '108271616' %}
Copy link
Collaborator

@stephenxs stephenxs Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got 108270592?

@noaOrMlnx
Copy link
Owner Author

noaOrMlnx commented Jan 20, 2025

@stephenxs Fixed buffer_defaults_t0/1.j2 files. thanks

@noaOrMlnx noaOrMlnx closed this Feb 5, 2025
noaOrMlnx pushed a commit that referenced this pull request Feb 18, 2025
@mssonicbld
[submodule] Update submodule sonic-stp to the latest HEAD automatical…
577a1f4 
…ly (sonic-net#21743)

#### Why I did it
src/sonic-stp
```
* 29eb387 - (HEAD -> master, origin/master, origin/HEAD) Fixing compilaion error for marvell_armhf (#47) (9 hours ago) [Divya Kumaran Chandralekha]
* b7da558 - Merge pull request #44 from wajahatrazi/stp_co_pr (3 days ago) [Divya Kumaran Chandralekha]
|\ 
| failure_prs.log skip_prs.log 47e1e77 - Merge branch 'master' into stp_co_pr (3 days ago) [Divya Kumaran Chandralekha]
| |\ 
| |/ 
|/| 
* | 6e4a94f - Merge pull request #46 from divyachandralekha/pvst_pr_1 (4 days ago) [Divya Kumaran Chandralekha]
|\ \ 
| failure_prs.log skip_prs.log | aa5e824 - libevent explicit building dependency removed (4 days ago) [Divya Chandralekha]
|/ / 
* | 9345e5a - Merge pull request #43 from omaaartamer/fix/alignment-warnings (5 days ago) [Divya Kumaran Chandralekha]
* | eedb772 - [stp] Add memory alignment padding to structures (9 weeks ago) [omaaartamer]
* | 128e53d - fix: resolve STP alignment warnings (9 weeks ago) [omaaartamer]
 / 
* 30febfa - Fixing changes in the code (9 weeks ago) [Wajahat Razi]
```
#### How I did it
#### How to verify it
#### Description for the changelog
noaOrMlnx pushed a commit that referenced this pull request Aug 18, 2025
@mssonicbld
[submodule] Update submodule dhcpmon to the latest HEAD automatically (…
018b0e7 
…sonic-net#23653)

#### Why I did it
src/dhcpmon
```
* 35a907b - (HEAD -> 202505, origin/202505) [build] Update to install libyang3 in PR check (#47) (2 days ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
noaOrMlnx pushed a commit that referenced this pull request Oct 26, 2025
@mssonicbld
[submodule][202412] Update submodule sonic-linux-kernel to the latest…
c85ab81 
… HEAD automatically (sonic-net#1345)

#### Why I did it
src/sonic-linux-kernel
```
* c16b6b2 - (HEAD -> 202412, origin/HEAD, origin/202412) Merge pull request #47 from mssonicbld/sonicbld/202412-merge (4 days ago) [mssonicbld]
* 06419f5 - Merge branch '202411' of https://github.com/sonic-net/sonic-linux-kernel into 202412 (4 days ago) [Sonic Automation]
* 276873a - [build] Use package.trafficmanager instead of sonicstorage.blob (sonic-net#494) (5 days ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephenxs stephenxs stephenxs approved these changes

@DavidZagury DavidZagury DavidZagury approved these changes

@dprital dprital dprital approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@noaOrMlnx @stephenxs @DavidZagury @dprital