Skip to content

feature/python3.13 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gecBurton wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feature/python3.13 #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/CI-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.9", "3.10", "3.11", "3.12"]
django-version: ["4.2.16", "5.0.9", "5.1.2"]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.12"]
Copy link
Owner

@nimasmi nimasmi Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Did you intend this to read "3.13", too?

django-version: ["4.2.16", "5.0.9", "5.1.2", "5.2.3"]
Copy link
Owner

@nimasmi nimasmi Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: We can drop tests for Django 5.0, support for which was ended in August 2024.

exclude:
# Django too new
- django-version: "5.0.9"
Expand Down Expand Up @@ -58,8 +58,8 @@ jobs:
needs: [build, lint]
strategy:
matrix:
python-version: ["3.9", "3.10", "3.11", "3.12"]
django-version: ["4.2.16", "5.0.9", "5.1.2"]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
django-version: ["4.2.16", "5.0.9", "5.1.2", "5.2.3"]
Copy link

@nickmoreton nickmoreton Jul 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
django-version: ["4.2.16", "5.0.9", "5.1.2", "5.2.3"]
django-version: ["4.2", "5.1", "5.2"]

Suggestion: This should save having to revise the versions when new patch releases become available

exclude:
# Django too new
- django-version: "5.0.9"
Expand Down
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## unreleased

### Features

- Support for Python 3.13
- Support Django 5.2

## 0.6.0 (2024-10-25)

### Features
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ This is implemented as a custom Django email backend. It presents a similar inte

django-gov-notify supports:

- Python 3.9, 3.10, 3.11 and 3.12
- Django 4.2, 5.0 and 5.1
- Python 3.9, 3.10, 3.11, 3.12 and 3.13
- Django 4.2, 5.0, 5.1 and 5.2
Copy link
Owner

@nimasmi nimasmi Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Let's drop support for Django 5.0 here, too.

Suggested change
- Django 4.2, 5.0, 5.1 and 5.2
- Django 4.2, 5.1 and 5.2


## Installation

Expand Down
6 changes: 4 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,20 @@ classifiers = [
"Framework :: Django :: 4.2",
"Framework :: Django :: 5.0",
Copy link
Owner

@nimasmi nimasmi Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Drop support for Django 5.0.

Suggested change
"Framework :: Django :: 5.0",

"Framework :: Django :: 5.1",
"Framework :: Django :: 5.2",
"License :: OSI Approved :: BSD License",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
]
license = "BSD-2-Clause"

[tool.poetry.dependencies]
python = ">=3.9,<3.13"
python = ">=3.9,<3.14"
django = [
{version = ">=4.2", python = ">=3.9,<3.13"},
{version = ">=4.2", python = ">=3.9,<3.14"},
]
notifications-python-client = "^8.1.0"

Expand Down