feature/python3.13 #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimasmi
reviewed
Jul 3, 2025
Owner
nimasmi
left a comment
nimasmi
left a comment
There was a problem hiding this comment.
Thanks for this contribution, and apologies for missing it last week.
| matrix: | ||
| python-version: ["3.9", "3.10", "3.11", "3.12"] | ||
| django-version: ["4.2.16", "5.0.9", "5.1.2"] | ||
| python-version: ["3.9", "3.10", "3.11", "3.12", "3.12"] |
Owner
There was a problem hiding this comment.
Question: Did you intend this to read "3.13", too?
| python-version: ["3.9", "3.10", "3.11", "3.12"] | ||
| django-version: ["4.2.16", "5.0.9", "5.1.2"] | ||
| python-version: ["3.9", "3.10", "3.11", "3.12", "3.12"] | ||
| django-version: ["4.2.16", "5.0.9", "5.1.2", "5.2.3"] |
Owner
There was a problem hiding this comment.
Suggestion: We can drop tests for Django 5.0, support for which was ended in August 2024.
| - Python 3.9, 3.10, 3.11 and 3.12 | ||
| - Django 4.2, 5.0 and 5.1 | ||
| - Python 3.9, 3.10, 3.11, 3.12 and 3.13 | ||
| - Django 4.2, 5.0, 5.1 and 5.2 |
Owner
There was a problem hiding this comment.
Suggestion: Let's drop support for Django 5.0 here, too.
Suggested change
| - Django 4.2, 5.0, 5.1 and 5.2 | |
| - Django 4.2, 5.1 and 5.2 |
| "Topic :: Communications :: Email", | ||
| "Framework :: Django", | ||
| "Framework :: Django :: 4.2", | ||
| "Framework :: Django :: 5.0", |
Owner
There was a problem hiding this comment.
Suggestion: Drop support for Django 5.0.
Suggested change
| "Framework :: Django :: 5.0", |
nickmoreton
suggested changes
Jul 4, 2025
| python-version: ["3.9", "3.10", "3.11", "3.12"] | ||
| django-version: ["4.2.16", "5.0.9", "5.1.2"] | ||
| python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"] | ||
| django-version: ["4.2.16", "5.0.9", "5.1.2", "5.2.3"] |
There was a problem hiding this comment.
Suggested change
| django-version: ["4.2.16", "5.0.9", "5.1.2", "5.2.3"] | |
| django-version: ["4.2", "5.1", "5.2"] |
Suggestion: This should save having to revise the versions when new patch releases become available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an Engineer I want to use the latest version of Python and Django
#16