Merged
Conversation
nikku
force-pushed
the
opimize-name-parsing
branch
2 times, most recently
from
aa9f7eb to
55c04c2
Compare
nikku
force-pushed
the
opimize-name-parsing
branch
2 times, most recently
from
855bb92 to
75067dd
Compare
As a shortcut to prevent expensive computation we instantiate a new `VariableContext` directly when setting a new key.
nikku
force-pushed
the
opimize-name-parsing
branch
from
71d5ff3 to
492eb02
Compare
nikku
force-pushed
the
opimize-name-parsing
branch
from
492eb02 to
035a309
Compare
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
On top of #70, this PR provides incremental improvements to further speed up FEEL expression parsing. It ships three optimizations:
O(1)normalizeContextKeyis only called once per key ➡️ reduces calls to the function during test suite execution from500.000❗ to6.244VariableContextwe instantiate the new context directly, instead of doing expensive key traversalAs a result we see another round of significant speedups, around
33%according to my tests.Existing tests verify this is a non-breaking change.
Before
Test execution time average around
~330ms, with spikes for large contexts.After
Test execution time average around
~210ms, speedup of~30%.Closes #59, #67