Conversation
Owner
Author
Verified 2e72fa7 is in fact not a breaking change: Old context executes with expected failures, fixed in this library via 2e72fa7, adjustments proposed downstream via bpmn-io/variable-resolver#62. Still draft, as I'm adding additional test coverage and root causing the discrepancy between built-in and custom context parsing. |
nikku
force-pushed
the
simplify-context-merging
branch
from
2e72fa7 to
12ef561
Compare
This was referenced Dec 4, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Related to #59 this PR yields significant performance enhancements in standard scenarios, for larger context sizes. Especially when context nesting happens then otherwise the parsing time rises exponentially.
Before
Overall test suite execution time:
3sAfter
Overall test suite execution time:
300msAs seen in 2e72fa7 this may be breaking with users of our internal extension points (overriding
VariableContext). I'm still in process of validating this.