Skip to content
This repository was archived by the owner on Oct 24, 2019. It is now read-only.

Conversation

@jung-han
Copy link
Member

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

change event binding way


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@jung-han jung-han requested a review from js87zz August 21, 2019 02:04
}
}
},
data() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memory leak 수정사항 반영 부분입니다.

@js87zz
Copy link
Contributor

js87zz commented Aug 21, 2019

리뷰 요청주신 부분은 이견없습니다. 👍 근데 보다보니.. 기존 invoke 메소드가 수정되어야겠네요..resetData할 때 data 배열을 const clonedData = JSON.parse(JSON.stringify(args[0]));하는 로직이 있는데 배열이 커지면 문제가 있을 것 같네요. 이 부분만 제거해주시면 될 것 같습니다!

@js87zz js87zz merged commit fe5e129 into master Aug 29, 2019
@js87zz js87zz deleted the feat/change-event-binding-way branch August 29, 2019 06:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants