Skip to content
This repository was archived by the owner on Oct 24, 2019. It is now read-only.

feat: change event binding way #10

Merged
merged 6 commits into from
Aug 29, 2019
Merged

feat: change event binding way #10

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ef9fd4f
feat: change event binding way
Aug 21, 2019
afa2474
fix: memory leak
Aug 21, 2019
7e98c35
fix: change destroy lifecycle
Aug 21, 2019
894ddb0
fix: memory leak, grid version update
Aug 21, 2019
25f7a8c
fix: remove event listeners on beforeDestroy
js87zz Aug 29, 2019
123ba52
fix: version up vulernerable dependencies
js87zz Aug 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion example/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ export default {
score: '5'
}
],
rowHeaders: ['checkbox'],
myTheme: {
name: 'myTheme',
value: {
Expand All @@ -143,6 +142,9 @@ export default {
}
}
}
},
options: {
rowHeaders: ['checkbox']
}
};
},
Expand Down
35 changes: 7 additions & 28 deletions src/Grid.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,6 @@
<script>
import Grid from 'tui-grid';

const gridEvents = [
'beforeRequest',
'check',
'click',
'collapse',
'dblclick',
'errorResponse',
'expand',
'failResponse',
'focusChange',
'mousedown',
'mouseout',
'mouseover',
'response',
'selection',
'successResponse',
'uncheck'
];

const presetTheme = ['default', 'striped', 'clean'];

const presetLanguage = ['en', 'ko'];
Expand Down Expand Up @@ -71,11 +52,6 @@ export default {
}
}
},
data() {
Copy link
Member Author

@jung-han jung-han Aug 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memory leak 수정사항 반영 부분입니다.

return {
gridInstance: null
};
},
mounted() {
const options = Object.assign({}, this.options, {
el: this.$refs.tuiGrid,
Expand All @@ -87,15 +63,18 @@ export default {
this.applyTheme();
this.setLanguage();
},
destroyed() {
gridEvents.forEach((eventName) => this.gridInstance.off(eventName));
beforeDestroy() {
for (const eventName of Object.keys(this.$listeners)) {
this.gridInstance.off(eventName);
}

this.gridInstance.destroy();
},
methods: {
addEventListeners() {
gridEvents.forEach((eventName) => {
for (const eventName of Object.keys(this.$listeners)) {
this.gridInstance.on(eventName, (...args) => this.$emit(eventName, ...args));
});
}
},
applyTheme() {
if (this.theme) {
Expand Down