Skip to content

Conversation

@sateeshperi
Copy link
Contributor

@sateeshperi sateeshperi commented Dec 3, 2025

  • Updated variable names in fasta_index_methylseq to use 'channel' instead of 'Channel' for consistency.
  • Renamed UNTAR to UNTAR_BISMARK and UNTAR_BWAMETH for clarity in fasta_index_methylseq.
  • Enhanced comments and descriptions in meta.yml files for better understanding of input and output structures.
  • Adjusted test cases in fastq_align_dedup workflows to reflect changes in input structure from single-end to paired-end.
  • Remove use_gpu param in bwamem workflow until proper integration @eduard-watchmaker

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!

sateeshperi and others added 3 commits December 3, 2025 12:57
… and consistency

- Updated variable names in fasta_index_methylseq to use 'channel' instead of 'Channel' for consistency.
- Renamed UNTAR to UNTAR_BISMARK and UNTAR_BWAMETH for clarity in fasta_index_methylseq.
- Enhanced comments and descriptions in meta.yml files for better understanding of input and output structures.
- Adjusted test cases in fastq_align_dedup workflows to reflect changes in input structure from single-end to paired-end.
- Updated version numbers in test snapshots to reflect recent changes.
@sateeshperi sateeshperi changed the title fix fasta_index_methylseq and fastq_align_dedup workflows for clarity… fix fasta_index_methylseq and fastq_align_dedup workflows Dec 3, 2025
Copy link
Contributor

@eduard-watchmaker eduard-watchmaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me, I will wait for the approval of the PR to implement fq2bam (gpu)

and thanks for the formatting and helping with consistency!

@sateeshperi sateeshperi enabled auto-merge December 3, 2025 16:01
@sateeshperi sateeshperi added this pull request to the merge queue Dec 3, 2025
Merged via the queue into master with commit 654daca Dec 3, 2025
67 checks passed
@sateeshperi sateeshperi deleted the fix-fasta-index-methylseq branch December 3, 2025 16:07
vagkaratzas pushed a commit that referenced this pull request Dec 8, 2025
* fix fasta_index_methylseq and fastq_align_dedup workflows for clarity and consistency

- Updated variable names in fasta_index_methylseq to use 'channel' instead of 'Channel' for consistency.
- Renamed UNTAR to UNTAR_BISMARK and UNTAR_BWAMETH for clarity in fasta_index_methylseq.
- Enhanced comments and descriptions in meta.yml files for better understanding of input and output structures.
- Adjusted test cases in fastq_align_dedup workflows to reflect changes in input structure from single-end to paired-end.
- Updated version numbers in test snapshots to reflect recent changes.

* fix: pre-commit lint fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants