Skip to content

chores: polish - strict syntax #8400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxulysse merged 5 commits into from
May 7, 2025
Merged

chores: polish - strict syntax #8400

maxulysse merged 5 commits into from
May 7, 2025

Conversation

@maxulysse
Copy link
Member

@maxulysse maxulysse commented May 6, 2025

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@maxulysse maxulysse requested a review from pinin4fjords as a code owner May 6, 2025 16:26
@maxulysse maxulysse mentioned this pull request May 6, 2025
Closed
@maxulysse maxulysse added this pull request to the merge queue May 7, 2025
Merged via the queue into nf-core:master with commit db5a844 May 7, 2025
61 checks passed
@maxulysse maxulysse deleted the rnaseq_strict_syntax branch May 7, 2025 10:46
zachary-foster pushed a commit to zachary-foster/modules that referenced this pull request May 8, 2025
@maxulysse
chores: polish - strict syntax (nf-core#8400)
0e2e368 
* chores: polish - strict syntax

* fix meta.yml

* gatk4

* no update this module

* move into its own PR
famosab pushed a commit to famosab/modules that referenced this pull request Jun 3, 2025
@maxulysse @famosab
chores: polish - strict syntax (nf-core#8400)
456b1a3 
* chores: polish - strict syntax

* fix meta.yml

* gatk4

* no update this module

* move into its own PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinin4fjords pinin4fjords pinin4fjords approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxulysse @pinin4fjords