Skip to content

Migrate genmap/map to nf-test #8279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SPPearce merged 3 commits into from
Apr 11, 2025
Merged

Migrate genmap/map to nf-test #8279

SPPearce merged 3 commits into from
Apr 11, 2025

Conversation

@LouisLeNezet
Copy link
Contributor

@LouisLeNezet LouisLeNezet commented Apr 11, 2025

PR checklist

Closes #7586

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@LouisLeNezet LouisLeNezet requested a review from a team April 11, 2025 14:12
@LouisLeNezet LouisLeNezet self-assigned this Apr 11, 2025
SPPearce
SPPearce requested changes Apr 11, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Todo to In Progress in nf-test Migration Apr 11, 2025
@LouisLeNezet LouisLeNezet requested a review from SPPearce April 11, 2025 20:56
SPPearce
SPPearce approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you muchly.

@SPPearce SPPearce added this pull request to the merge queue Apr 11, 2025
Merged via the queue into nf-core:master with commit b420233 Apr 11, 2025
67 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in nf-test Migration Apr 11, 2025
vagkaratzas pushed a commit that referenced this pull request Apr 12, 2025
@LouisLeNezet @vagkaratzas
Migrate genmap/map to nf-test (#8279)
bfb6fb0 
* Migrate to nf-test

* Update prefix

---------

Co-authored-by: LouisLeNezet <[email protected]>
@LouisLeNezet LouisLeNezet deleted the genmap branch April 24, 2025 07:44
famosab pushed a commit to famosab/modules that referenced this pull request Jun 3, 2025
@LouisLeNezet @famosab
Migrate genmap/map to nf-test (nf-core#8279)
6b11f32 
* Migrate to nf-test

* Update prefix

---------

Co-authored-by: LouisLeNezet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SPPearce SPPearce SPPearce approved these changes

Assignees

@LouisLeNezet LouisLeNezet

Labels

nf-test

Projects

nf-test Migration
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

nf-test migration: genmap/map

2 participants

@LouisLeNezet @SPPearce