Skip to content

Conversation

@prototaxites
Copy link
Contributor

@prototaxites prototaxites commented Mar 19, 2025

Apologies, this ended up being a much bigger PR than I first anticipated... seemed easier to roll everything into a single change than to do multiple PRs picking up little bits of this. All the changes are pretty similar across modules though.

  • Updates FastK to version 1.1 (now in bioconda)
  • Updates MerquryFK to version 1.1.1 (also now in bioconda)
    • Note that this requires pinning ggplot2 at >=3.4.0, <3.5.0
  • Both these modules now have a conda option and share a single Seqera container
  • Tidy all merquryfk output channels so that PNG and PDF are emitted from a single channel
  • Port all tests to nf-test
  • Add merquryfk/hapmaker module

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@prototaxites prototaxites requested a review from a team March 19, 2025 10:04
@prototaxites prototaxites added the WIP Work in progress label Mar 19, 2025
@prototaxites
Copy link
Contributor Author

OK, think this looks ready to go. The linting error looks like a bug in the linter - it's imagining an extra entry in one of the output tuples (ap_ktab). I've checked for e.g. hidden characters and the like and not spotted anything:

Module meta.yml does not match main.nf. Outputs should contain: {'mathap_ktab': ['meta', '${input_mat}.hap.ktab", hidden: true'], 'pathap_ktab': ['meta2', '${input_pat}.hap.ktab", hidden: true', 'ap_ktab'], 'versions': ['versions.yml']}

@prototaxites prototaxites added Ready for Review and removed WIP Work in progress labels Mar 19, 2025
@SPPearce SPPearce requested a review from itrujnara March 20, 2025 15:52
Copy link
Contributor

@itrujnara itrujnara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a massive amount of work, and the overall quality is quite good. I've left some improvement suggestions here and there.

@prototaxites
Copy link
Contributor Author

Thanks for the review! I think I've addressed everything, but let me know if there's anything I've missed :)

Copy link
Contributor

@itrujnara itrujnara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, no more issues from my side

@prototaxites prototaxites added this pull request to the merge queue Mar 21, 2025
Merged via the queue into nf-core:master with commit 26ae045 Mar 21, 2025
70 checks passed
@prototaxites prototaxites deleted the merquryfk branch March 21, 2025 09:53
@SPPearce
Copy link
Contributor

Just to add, please split PRs like this up into individual chunks (i.e. one module at a time), it makes it much easier to review.

bruno-ariano pushed a commit to HTGenomeAnalysisUnit/nf-core-modules that referenced this pull request Mar 24, 2025
…er module, port to nf-test (nf-core#7847)

* Start updating FastK modules to allow conda

* Migrate all Merquryfk modules to nf-test

* Update to container with explicit R

* Fix container for FastK

* Start fixing fastk modules

* Fix FastK tests, add merquryfk/hapmaker module

* Fix linting for some merquryFK modules

* Fix merquryfk/merquryfk linting

* Fix linting for everything except hapmaker

* Fix snapshots?

* Update tests

* Fix tests pt 1000

* Sort fastk/merge test inputs to try and ensure repeatability

* Rename output channels to avoid linting error

* Fix hapmaker snapshot

* Harshill alignment

* Stub output format determined by args; add details to meta.yml files to disambiguate meta maps

* Remove def again from variables - causes error otherwise

* Fix Fastk/merge stub

* Update snapshot
github-merge-queue bot pushed a commit that referenced this pull request Mar 26, 2025
* Module for PCA

* Module for PCA

* Module for PCA

* Module for PCA

* Module for PCA

* testing conda

* plinkpca

* Fixed ivar modules (#7868)

* fixed ivar variants module

* updated snapshot ivar variants because versions change

* fixed ivar consensus module

* simplified snapshot for consensus test, same as ivar variants module

* simplified snapshot for trim test, same as ivar variants module

* updated snapshot for ivar trim and consensus modules

* removed empty log file in ivar trim in snapshot

* updated ivar version to last one

* updated version also in conda env

* updated version also in conda env in ivar consensus and variants

* updated container version for ivar consensus and variants

* updated snapshots again

* Update FastK + MerquryFK versions + allow conda, add merquryfk/hapmaker module, port to nf-test (#7847)

* Start updating FastK modules to allow conda

* Migrate all Merquryfk modules to nf-test

* Update to container with explicit R

* Fix container for FastK

* Start fixing fastk modules

* Fix FastK tests, add merquryfk/hapmaker module

* Fix linting for some merquryFK modules

* Fix merquryfk/merquryfk linting

* Fix linting for everything except hapmaker

* Fix snapshots?

* Update tests

* Fix tests pt 1000

* Sort fastk/merge test inputs to try and ensure repeatability

* Rename output channels to avoid linting error

* Fix hapmaker snapshot

* Harshill alignment

* Stub output format determined by args; add details to meta.yml files to disambiguate meta maps

* Remove def again from variables - causes error otherwise

* Fix Fastk/merge stub

* Update snapshot

* Fix rnaseq preprocessing: don't trim with bad linting (#7881)

* Update versions for motus/preplong (#7854)

* Update versions for motus preplong

* Update modules/nf-core/motus/preplong/main.nf

Co-authored-by: Lili Andersson-Li <[email protected]>

* Versions

* Add tests for downloaddb

* Add snapshot

* Update to the latest motus merge

* Update motus merge

* Remove pytest

* Update pytest

* Update downloaddb

* Update modules/nf-core/motus/downloaddb/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/motus/preplong/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Add stub

* Add stub

---------

Co-authored-by: Lili Andersson-Li <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>

* Fixed conda channel order for fq module (#7871) (#7873)

* Fixed conda channel order for fq module (#7871)

By listing bioconda as the primary channel, the fq package can be installed and used in conda environments.

modified:   modules/nf-core/fq/generate/environment.yml
modified:   modules/nf-core/fq/lint/environment.yml
modified:   modules/nf-core/fq/subsample/environment.yml

* added channel order comment to avoid a regression

---------

Co-authored-by: Angel Pizarro <[email protected]>

* New module:  `khmer/trimlowabund` (#7806)

* add khmer/trimlowabund

* use evironment.yml

* chore(deps): update tj-actions/changed-files action to v46 (#7809)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Added coreograph nf-test (#7812)

coreograph nf-test

* Added ilastik/multicut nftest (#7811)

* main.nf changes

* finished test

* Update `graphtyper/vcfconcatenate`: Add batching to avoid long command line error (#7805)

add batching to vcfconcatenate to avoid long command line error

Co-authored-by: Zachary Foster <[email protected]>

* basicpy nf-test (#7772)

* basicpy nf-test

* removed leftover pytest

* separate output files

* updated meta

* separated outputs

* adapted test

* adapted inputs and snapshot

* removed pytest files

---------

Co-authored-by: Simon Pearce <[email protected]>

* Clair3 (#7765)

* Adds Clair3

* Removes TODOs and changes container urls

* Changes bash command

* Removes useless code lines

* Removes TODO statements

* Update meta.yml

adds more file info to meta.yml

* Update main.nf.test

removes TODO and updates clair3 model directory

* Update meta.yml
fixes doi link

* Add suggestions and changes data pulling

* Fix main.nf.test
adds correct structure to pass data to main

* fix yaml

* fix yaml
final one

* Update test snapshot

* Fix snapshot

* Fix tests

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Famke Bäuerle <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Famke Bäuerle <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Famke Bäuerle <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/clair3/meta.yml

Co-authored-by: Simon Pearce <[email protected]>

* Change meta description

* Update meta

* Update meta

* update screenshot

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Simon Pearce <[email protected]>

---------

Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>

* chore(deps): update github actions (#7796)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Change file name for severus_somatic.vcf (#7814)

* Change file name for severus_somatic.vcf

* Update snapshot

* Update yaml

* Clean up hifiasm module + add bin file input (#7802)

* Tidy hifiasm model + update tests

* Update nf.test

* Fix linting

* Add fasta and PAF outputs to hifiasm; combine all bin files into a single output channel. Update documentation

* Improve descriptiveness of output channel names

* fix samtools/convert stub (#7816)

* add default memory if task.memory is not set

* Update modules/nf-core/khmer/trimlowabund/meta.yml

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/khmer/trimlowabund/meta.yml

Co-authored-by: Simon Pearce <[email protected]>

* Update `sourmash/compare`: Name output by prefix and update conda/docker (#7808)

* update sourmash/compare so output is named by prefix

* add stub to sourmash/sketch

* Update modules/nf-core/sourmash/sketch/tests/main.nf.test

Co-authored-by: Simon Pearce <[email protected]>

* move test for sourmash/gather from pytest to nf-test

* migrated sourmash taxannotate to nf-test

---------

Co-authored-by: Zachary Foster <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>

* add Subworkflow linting step to CI (#7835)

add swf linting step

* Add missing swf change detection (#7836)

* add swf linting step

* add missing change detection for subworkflows

* Add bedtools/shuffle module (#7803)

* Add bedtools/shuffle module

* Make linter happy

* Update test snapshots for bedtools/shuffle

* add new ARCHIVE_EXTRACT subworkflow (#7817)

* add new subworkflow

* rename

* fix tags

* add basic meta.yml

* better comments

* Update subworkflows/nf-core/archive_extract/main.nf

Co-authored-by: Simon Pearce <[email protected]>

---------

Co-authored-by: Simon Pearce <[email protected]>

* APPLYBQSR output line specificity  (#7818)

* updated output line and snap file

* linting fix in meta

* Trying out RunsOn runners (#7840)

* Trying out RunsOn runners

* try older image

* add debugging

* fix action

* pin setup-apptainer

* add gpu test

* fix usage syntax

* switch from docker_self_hosted to docker

* remove test comments

* Fix language server error in salmon/quant (#7843)

* New module: `busco/download` (#7788)

* add busco/download

* add author/maintainer

* update tests snap for new conda version

* revert to older conda version to match container versions

* update tests

* add stub

* removed unneeded code in stub

---------

Co-authored-by: Zachary Foster <[email protected]>

* Fix language server errors in arriba/arriba (#7845)

* name output by prefix

* set to process_medium

* check if input and output file are the same

* make sure regex matches only part of string

* Update modules/nf-core/khmer/trimlowabund/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/khmer/trimlowabund/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* apply changes made to file path handeling to stub

* Update modules/nf-core/khmer/trimlowabund/meta.yml

* Update modules/nf-core/khmer/trimlowabund/meta.yml

---------

Co-authored-by: Zachary Foster <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Krešimir Beštak <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>
Co-authored-by: robert-a-forsyth <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Jim Downie <[email protected]>
Co-authored-by: Nicolas Vannieuwkerke <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Igor Trujnara <[email protected]>
Co-authored-by: Maxime U Garcia <[email protected]>
Co-authored-by: John Orgera <[email protected]>

* Added cram output to samtools/fixmate (#7820)

* Added cram output to samtools/fixmate

* Fixed tag

* Fixed tag

* Fixed linting

* Updated onts

* Use nft-bam, update output glob

* Fixed meta.yml

---------

Co-authored-by: Simon Pearce <[email protected]>

* Migrate `ATAQV/MKARV` to nf-test (#7893)

Migrate to nf-test

Co-authored-by: LouisLeNezet <[email protected]>

* Added repeatmasker/repeatmasker (#7825)

* Added repeatmasker/repeatmasker

* Added onts

* Added mdust (#7823)

* Added mdust

* Responded to review

* Added agat/spfilterbyorfsize (#7822)

* Added agat/spfilterbyorfsize

* Added Gff tests

* Migrate `authentict/deam2cont` to nf-test (#7947)

* Update to nf-test

* Fix samtools version

* Update modules/nf-core/authentict/deam2cont/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/authentict/deam2cont/tests/main.nf.test

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/authentict/deam2cont/tests/main.nf.test

Co-authored-by: Simon Pearce <[email protected]>

---------

Co-authored-by: Simon Pearce <[email protected]>

* Migrate `BAMTOOLS/CONVERT` to nf-test (#7958)

* Migrate  to nf-test

* Update modules/nf-core/bamtools/convert/main.nf

Co-authored-by: Felix Lenner <[email protected]>

* Update modules/nf-core/bamtools/convert/tests/main.nf.test

Co-authored-by: Felix Lenner <[email protected]>

* Update modules/nf-core/bamtools/convert/tests/main.nf.test

Co-authored-by: Felix Lenner <[email protected]>

* Update modules/nf-core/bamtools/convert/tests/main.nf.test

Co-authored-by: Felix Lenner <[email protected]>

* Update variable names

* Fix spacing

---------

Co-authored-by: Felix Lenner <[email protected]>

* Updated deevariant to avoid failing nf-test (#7960)

Updated the main to avoid failing nf-test

* answer review Edo

* fixing logfile

* fixing variable name bug

* rebasing

* fixing variable name bug

* fixing variable name bug

---------

Co-authored-by: Bruno Ariano <[email protected]>
Co-authored-by: Sara Monzón <[email protected]>
Co-authored-by: Jim Downie <[email protected]>
Co-authored-by: Jonathan Manning <[email protected]>
Co-authored-by: Sofia Stamouli <[email protected]>
Co-authored-by: Lili Andersson-Li <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>
Co-authored-by: Angel Pizarro <[email protected]>
Co-authored-by: Angel Pizarro <[email protected]>
Co-authored-by: Zachary Foster <[email protected]>
Co-authored-by: Zachary Foster <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Krešimir Beštak <[email protected]>
Co-authored-by: robert-a-forsyth <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Nicolas Vannieuwkerke <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Igor Trujnara <[email protected]>
Co-authored-by: Maxime U Garcia <[email protected]>
Co-authored-by: John Orgera <[email protected]>
Co-authored-by: Usman Rashid <[email protected]>
Co-authored-by: Louis Le Nézet <[email protected]>
Co-authored-by: LouisLeNezet <[email protected]>
Co-authored-by: Felix Lenner <[email protected]>
Co-authored-by: Solenne Correard <[email protected]>
zachary-foster pushed a commit to zachary-foster/modules that referenced this pull request Mar 27, 2025
…er module, port to nf-test (nf-core#7847)

* Start updating FastK modules to allow conda

* Migrate all Merquryfk modules to nf-test

* Update to container with explicit R

* Fix container for FastK

* Start fixing fastk modules

* Fix FastK tests, add merquryfk/hapmaker module

* Fix linting for some merquryFK modules

* Fix merquryfk/merquryfk linting

* Fix linting for everything except hapmaker

* Fix snapshots?

* Update tests

* Fix tests pt 1000

* Sort fastk/merge test inputs to try and ensure repeatability

* Rename output channels to avoid linting error

* Fix hapmaker snapshot

* Harshill alignment

* Stub output format determined by args; add details to meta.yml files to disambiguate meta maps

* Remove def again from variables - causes error otherwise

* Fix Fastk/merge stub

* Update snapshot
zachary-foster added a commit to zachary-foster/modules that referenced this pull request Mar 27, 2025
* Module for PCA

* Module for PCA

* Module for PCA

* Module for PCA

* Module for PCA

* testing conda

* plinkpca

* Fixed ivar modules (nf-core#7868)

* fixed ivar variants module

* updated snapshot ivar variants because versions change

* fixed ivar consensus module

* simplified snapshot for consensus test, same as ivar variants module

* simplified snapshot for trim test, same as ivar variants module

* updated snapshot for ivar trim and consensus modules

* removed empty log file in ivar trim in snapshot

* updated ivar version to last one

* updated version also in conda env

* updated version also in conda env in ivar consensus and variants

* updated container version for ivar consensus and variants

* updated snapshots again

* Update FastK + MerquryFK versions + allow conda, add merquryfk/hapmaker module, port to nf-test (nf-core#7847)

* Start updating FastK modules to allow conda

* Migrate all Merquryfk modules to nf-test

* Update to container with explicit R

* Fix container for FastK

* Start fixing fastk modules

* Fix FastK tests, add merquryfk/hapmaker module

* Fix linting for some merquryFK modules

* Fix merquryfk/merquryfk linting

* Fix linting for everything except hapmaker

* Fix snapshots?

* Update tests

* Fix tests pt 1000

* Sort fastk/merge test inputs to try and ensure repeatability

* Rename output channels to avoid linting error

* Fix hapmaker snapshot

* Harshill alignment

* Stub output format determined by args; add details to meta.yml files to disambiguate meta maps

* Remove def again from variables - causes error otherwise

* Fix Fastk/merge stub

* Update snapshot

* Fix rnaseq preprocessing: don't trim with bad linting (nf-core#7881)

* Update versions for motus/preplong (nf-core#7854)

* Update versions for motus preplong

* Update modules/nf-core/motus/preplong/main.nf

Co-authored-by: Lili Andersson-Li <[email protected]>

* Versions

* Add tests for downloaddb

* Add snapshot

* Update to the latest motus merge

* Update motus merge

* Remove pytest

* Update pytest

* Update downloaddb

* Update modules/nf-core/motus/downloaddb/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/motus/preplong/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Add stub

* Add stub

---------

Co-authored-by: Lili Andersson-Li <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>

* Fixed conda channel order for fq module (nf-core#7871) (nf-core#7873)

* Fixed conda channel order for fq module (nf-core#7871)

By listing bioconda as the primary channel, the fq package can be installed and used in conda environments.

modified:   modules/nf-core/fq/generate/environment.yml
modified:   modules/nf-core/fq/lint/environment.yml
modified:   modules/nf-core/fq/subsample/environment.yml

* added channel order comment to avoid a regression

---------

Co-authored-by: Angel Pizarro <[email protected]>

* New module:  `khmer/trimlowabund` (nf-core#7806)

* add khmer/trimlowabund

* use evironment.yml

* chore(deps): update tj-actions/changed-files action to v46 (nf-core#7809)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Added coreograph nf-test (nf-core#7812)

coreograph nf-test

* Added ilastik/multicut nftest (nf-core#7811)

* main.nf changes

* finished test

* Update `graphtyper/vcfconcatenate`: Add batching to avoid long command line error (nf-core#7805)

add batching to vcfconcatenate to avoid long command line error

Co-authored-by: Zachary Foster <[email protected]>

* basicpy nf-test (nf-core#7772)

* basicpy nf-test

* removed leftover pytest

* separate output files

* updated meta

* separated outputs

* adapted test

* adapted inputs and snapshot

* removed pytest files

---------

Co-authored-by: Simon Pearce <[email protected]>

* Clair3 (nf-core#7765)

* Adds Clair3

* Removes TODOs and changes container urls

* Changes bash command

* Removes useless code lines

* Removes TODO statements

* Update meta.yml

adds more file info to meta.yml

* Update main.nf.test

removes TODO and updates clair3 model directory

* Update meta.yml
fixes doi link

* Add suggestions and changes data pulling

* Fix main.nf.test
adds correct structure to pass data to main

* fix yaml

* fix yaml
final one

* Update test snapshot

* Fix snapshot

* Fix tests

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Famke Bäuerle <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Famke Bäuerle <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Famke Bäuerle <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/clair3/meta.yml

Co-authored-by: Simon Pearce <[email protected]>

* Change meta description

* Update meta

* Update meta

* update screenshot

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Simon Pearce <[email protected]>

---------

Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>

* chore(deps): update github actions (nf-core#7796)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Change file name for severus_somatic.vcf (nf-core#7814)

* Change file name for severus_somatic.vcf

* Update snapshot

* Update yaml

* Clean up hifiasm module + add bin file input (nf-core#7802)

* Tidy hifiasm model + update tests

* Update nf.test

* Fix linting

* Add fasta and PAF outputs to hifiasm; combine all bin files into a single output channel. Update documentation

* Improve descriptiveness of output channel names

* fix samtools/convert stub (nf-core#7816)

* add default memory if task.memory is not set

* Update modules/nf-core/khmer/trimlowabund/meta.yml

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/khmer/trimlowabund/meta.yml

Co-authored-by: Simon Pearce <[email protected]>

* Update `sourmash/compare`: Name output by prefix and update conda/docker (nf-core#7808)

* update sourmash/compare so output is named by prefix

* add stub to sourmash/sketch

* Update modules/nf-core/sourmash/sketch/tests/main.nf.test

Co-authored-by: Simon Pearce <[email protected]>

* move test for sourmash/gather from pytest to nf-test

* migrated sourmash taxannotate to nf-test

---------

Co-authored-by: Zachary Foster <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>

* add Subworkflow linting step to CI (nf-core#7835)

add swf linting step

* Add missing swf change detection (nf-core#7836)

* add swf linting step

* add missing change detection for subworkflows

* Add bedtools/shuffle module (nf-core#7803)

* Add bedtools/shuffle module

* Make linter happy

* Update test snapshots for bedtools/shuffle

* add new ARCHIVE_EXTRACT subworkflow (nf-core#7817)

* add new subworkflow

* rename

* fix tags

* add basic meta.yml

* better comments

* Update subworkflows/nf-core/archive_extract/main.nf

Co-authored-by: Simon Pearce <[email protected]>

---------

Co-authored-by: Simon Pearce <[email protected]>

* APPLYBQSR output line specificity  (nf-core#7818)

* updated output line and snap file

* linting fix in meta

* Trying out RunsOn runners (nf-core#7840)

* Trying out RunsOn runners

* try older image

* add debugging

* fix action

* pin setup-apptainer

* add gpu test

* fix usage syntax

* switch from docker_self_hosted to docker

* remove test comments

* Fix language server error in salmon/quant (nf-core#7843)

* New module: `busco/download` (nf-core#7788)

* add busco/download

* add author/maintainer

* update tests snap for new conda version

* revert to older conda version to match container versions

* update tests

* add stub

* removed unneeded code in stub

---------

Co-authored-by: Zachary Foster <[email protected]>

* Fix language server errors in arriba/arriba (nf-core#7845)

* name output by prefix

* set to process_medium

* check if input and output file are the same

* make sure regex matches only part of string

* Update modules/nf-core/khmer/trimlowabund/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/khmer/trimlowabund/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* apply changes made to file path handeling to stub

* Update modules/nf-core/khmer/trimlowabund/meta.yml

* Update modules/nf-core/khmer/trimlowabund/meta.yml

---------

Co-authored-by: Zachary Foster <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Krešimir Beštak <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>
Co-authored-by: robert-a-forsyth <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Jim Downie <[email protected]>
Co-authored-by: Nicolas Vannieuwkerke <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Igor Trujnara <[email protected]>
Co-authored-by: Maxime U Garcia <[email protected]>
Co-authored-by: John Orgera <[email protected]>

* Added cram output to samtools/fixmate (nf-core#7820)

* Added cram output to samtools/fixmate

* Fixed tag

* Fixed tag

* Fixed linting

* Updated onts

* Use nft-bam, update output glob

* Fixed meta.yml

---------

Co-authored-by: Simon Pearce <[email protected]>

* Migrate `ATAQV/MKARV` to nf-test (nf-core#7893)

Migrate to nf-test

Co-authored-by: LouisLeNezet <[email protected]>

* Added repeatmasker/repeatmasker (nf-core#7825)

* Added repeatmasker/repeatmasker

* Added onts

* Added mdust (nf-core#7823)

* Added mdust

* Responded to review

* Added agat/spfilterbyorfsize (nf-core#7822)

* Added agat/spfilterbyorfsize

* Added Gff tests

* Migrate `authentict/deam2cont` to nf-test (nf-core#7947)

* Update to nf-test

* Fix samtools version

* Update modules/nf-core/authentict/deam2cont/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/authentict/deam2cont/tests/main.nf.test

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/authentict/deam2cont/tests/main.nf.test

Co-authored-by: Simon Pearce <[email protected]>

---------

Co-authored-by: Simon Pearce <[email protected]>

* Migrate `BAMTOOLS/CONVERT` to nf-test (nf-core#7958)

* Migrate  to nf-test

* Update modules/nf-core/bamtools/convert/main.nf

Co-authored-by: Felix Lenner <[email protected]>

* Update modules/nf-core/bamtools/convert/tests/main.nf.test

Co-authored-by: Felix Lenner <[email protected]>

* Update modules/nf-core/bamtools/convert/tests/main.nf.test

Co-authored-by: Felix Lenner <[email protected]>

* Update modules/nf-core/bamtools/convert/tests/main.nf.test

Co-authored-by: Felix Lenner <[email protected]>

* Update variable names

* Fix spacing

---------

Co-authored-by: Felix Lenner <[email protected]>

* Updated deevariant to avoid failing nf-test (nf-core#7960)

Updated the main to avoid failing nf-test

* answer review Edo

* fixing logfile

* fixing variable name bug

* rebasing

* fixing variable name bug

* fixing variable name bug

---------

Co-authored-by: Bruno Ariano <[email protected]>
Co-authored-by: Sara Monzón <[email protected]>
Co-authored-by: Jim Downie <[email protected]>
Co-authored-by: Jonathan Manning <[email protected]>
Co-authored-by: Sofia Stamouli <[email protected]>
Co-authored-by: Lili Andersson-Li <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>
Co-authored-by: Angel Pizarro <[email protected]>
Co-authored-by: Angel Pizarro <[email protected]>
Co-authored-by: Zachary Foster <[email protected]>
Co-authored-by: Zachary Foster <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Krešimir Beštak <[email protected]>
Co-authored-by: robert-a-forsyth <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Nicolas Vannieuwkerke <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Igor Trujnara <[email protected]>
Co-authored-by: Maxime U Garcia <[email protected]>
Co-authored-by: John Orgera <[email protected]>
Co-authored-by: Usman Rashid <[email protected]>
Co-authored-by: Louis Le Nézet <[email protected]>
Co-authored-by: LouisLeNezet <[email protected]>
Co-authored-by: Felix Lenner <[email protected]>
Co-authored-by: Solenne Correard <[email protected]>
Dewey-Wang pushed a commit to Dewey-Wang/modules that referenced this pull request Mar 28, 2025
* Module for PCA

* Module for PCA

* Module for PCA

* Module for PCA

* Module for PCA

* testing conda

* plinkpca

* Fixed ivar modules (nf-core#7868)

* fixed ivar variants module

* updated snapshot ivar variants because versions change

* fixed ivar consensus module

* simplified snapshot for consensus test, same as ivar variants module

* simplified snapshot for trim test, same as ivar variants module

* updated snapshot for ivar trim and consensus modules

* removed empty log file in ivar trim in snapshot

* updated ivar version to last one

* updated version also in conda env

* updated version also in conda env in ivar consensus and variants

* updated container version for ivar consensus and variants

* updated snapshots again

* Update FastK + MerquryFK versions + allow conda, add merquryfk/hapmaker module, port to nf-test (nf-core#7847)

* Start updating FastK modules to allow conda

* Migrate all Merquryfk modules to nf-test

* Update to container with explicit R

* Fix container for FastK

* Start fixing fastk modules

* Fix FastK tests, add merquryfk/hapmaker module

* Fix linting for some merquryFK modules

* Fix merquryfk/merquryfk linting

* Fix linting for everything except hapmaker

* Fix snapshots?

* Update tests

* Fix tests pt 1000

* Sort fastk/merge test inputs to try and ensure repeatability

* Rename output channels to avoid linting error

* Fix hapmaker snapshot

* Harshill alignment

* Stub output format determined by args; add details to meta.yml files to disambiguate meta maps

* Remove def again from variables - causes error otherwise

* Fix Fastk/merge stub

* Update snapshot

* Fix rnaseq preprocessing: don't trim with bad linting (nf-core#7881)

* Update versions for motus/preplong (nf-core#7854)

* Update versions for motus preplong

* Update modules/nf-core/motus/preplong/main.nf

Co-authored-by: Lili Andersson-Li <[email protected]>

* Versions

* Add tests for downloaddb

* Add snapshot

* Update to the latest motus merge

* Update motus merge

* Remove pytest

* Update pytest

* Update downloaddb

* Update modules/nf-core/motus/downloaddb/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/motus/preplong/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Add stub

* Add stub

---------

Co-authored-by: Lili Andersson-Li <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>

* Fixed conda channel order for fq module (nf-core#7871) (nf-core#7873)

* Fixed conda channel order for fq module (nf-core#7871)

By listing bioconda as the primary channel, the fq package can be installed and used in conda environments.

modified:   modules/nf-core/fq/generate/environment.yml
modified:   modules/nf-core/fq/lint/environment.yml
modified:   modules/nf-core/fq/subsample/environment.yml

* added channel order comment to avoid a regression

---------

Co-authored-by: Angel Pizarro <[email protected]>

* New module:  `khmer/trimlowabund` (nf-core#7806)

* add khmer/trimlowabund

* use evironment.yml

* chore(deps): update tj-actions/changed-files action to v46 (nf-core#7809)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Added coreograph nf-test (nf-core#7812)

coreograph nf-test

* Added ilastik/multicut nftest (nf-core#7811)

* main.nf changes

* finished test

* Update `graphtyper/vcfconcatenate`: Add batching to avoid long command line error (nf-core#7805)

add batching to vcfconcatenate to avoid long command line error

Co-authored-by: Zachary Foster <[email protected]>

* basicpy nf-test (nf-core#7772)

* basicpy nf-test

* removed leftover pytest

* separate output files

* updated meta

* separated outputs

* adapted test

* adapted inputs and snapshot

* removed pytest files

---------

Co-authored-by: Simon Pearce <[email protected]>

* Clair3 (nf-core#7765)

* Adds Clair3

* Removes TODOs and changes container urls

* Changes bash command

* Removes useless code lines

* Removes TODO statements

* Update meta.yml

adds more file info to meta.yml

* Update main.nf.test

removes TODO and updates clair3 model directory

* Update meta.yml
fixes doi link

* Add suggestions and changes data pulling

* Fix main.nf.test
adds correct structure to pass data to main

* fix yaml

* fix yaml
final one

* Update test snapshot

* Fix snapshot

* Fix tests

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Famke Bäuerle <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Famke Bäuerle <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Famke Bäuerle <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/clair3/meta.yml

Co-authored-by: Simon Pearce <[email protected]>

* Change meta description

* Update meta

* Update meta

* update screenshot

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Simon Pearce <[email protected]>

---------

Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>

* chore(deps): update github actions (nf-core#7796)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Change file name for severus_somatic.vcf (nf-core#7814)

* Change file name for severus_somatic.vcf

* Update snapshot

* Update yaml

* Clean up hifiasm module + add bin file input (nf-core#7802)

* Tidy hifiasm model + update tests

* Update nf.test

* Fix linting

* Add fasta and PAF outputs to hifiasm; combine all bin files into a single output channel. Update documentation

* Improve descriptiveness of output channel names

* fix samtools/convert stub (nf-core#7816)

* add default memory if task.memory is not set

* Update modules/nf-core/khmer/trimlowabund/meta.yml

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/khmer/trimlowabund/meta.yml

Co-authored-by: Simon Pearce <[email protected]>

* Update `sourmash/compare`: Name output by prefix and update conda/docker (nf-core#7808)

* update sourmash/compare so output is named by prefix

* add stub to sourmash/sketch

* Update modules/nf-core/sourmash/sketch/tests/main.nf.test

Co-authored-by: Simon Pearce <[email protected]>

* move test for sourmash/gather from pytest to nf-test

* migrated sourmash taxannotate to nf-test

---------

Co-authored-by: Zachary Foster <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>

* add Subworkflow linting step to CI (nf-core#7835)

add swf linting step

* Add missing swf change detection (nf-core#7836)

* add swf linting step

* add missing change detection for subworkflows

* Add bedtools/shuffle module (nf-core#7803)

* Add bedtools/shuffle module

* Make linter happy

* Update test snapshots for bedtools/shuffle

* add new ARCHIVE_EXTRACT subworkflow (nf-core#7817)

* add new subworkflow

* rename

* fix tags

* add basic meta.yml

* better comments

* Update subworkflows/nf-core/archive_extract/main.nf

Co-authored-by: Simon Pearce <[email protected]>

---------

Co-authored-by: Simon Pearce <[email protected]>

* APPLYBQSR output line specificity  (nf-core#7818)

* updated output line and snap file

* linting fix in meta

* Trying out RunsOn runners (nf-core#7840)

* Trying out RunsOn runners

* try older image

* add debugging

* fix action

* pin setup-apptainer

* add gpu test

* fix usage syntax

* switch from docker_self_hosted to docker

* remove test comments

* Fix language server error in salmon/quant (nf-core#7843)

* New module: `busco/download` (nf-core#7788)

* add busco/download

* add author/maintainer

* update tests snap for new conda version

* revert to older conda version to match container versions

* update tests

* add stub

* removed unneeded code in stub

---------

Co-authored-by: Zachary Foster <[email protected]>

* Fix language server errors in arriba/arriba (nf-core#7845)

* name output by prefix

* set to process_medium

* check if input and output file are the same

* make sure regex matches only part of string

* Update modules/nf-core/khmer/trimlowabund/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/khmer/trimlowabund/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* apply changes made to file path handeling to stub

* Update modules/nf-core/khmer/trimlowabund/meta.yml

* Update modules/nf-core/khmer/trimlowabund/meta.yml

---------

Co-authored-by: Zachary Foster <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Krešimir Beštak <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>
Co-authored-by: robert-a-forsyth <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Jim Downie <[email protected]>
Co-authored-by: Nicolas Vannieuwkerke <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Igor Trujnara <[email protected]>
Co-authored-by: Maxime U Garcia <[email protected]>
Co-authored-by: John Orgera <[email protected]>

* Added cram output to samtools/fixmate (nf-core#7820)

* Added cram output to samtools/fixmate

* Fixed tag

* Fixed tag

* Fixed linting

* Updated onts

* Use nft-bam, update output glob

* Fixed meta.yml

---------

Co-authored-by: Simon Pearce <[email protected]>

* Migrate `ATAQV/MKARV` to nf-test (nf-core#7893)

Migrate to nf-test

Co-authored-by: LouisLeNezet <[email protected]>

* Added repeatmasker/repeatmasker (nf-core#7825)

* Added repeatmasker/repeatmasker

* Added onts

* Added mdust (nf-core#7823)

* Added mdust

* Responded to review

* Added agat/spfilterbyorfsize (nf-core#7822)

* Added agat/spfilterbyorfsize

* Added Gff tests

* Migrate `authentict/deam2cont` to nf-test (nf-core#7947)

* Update to nf-test

* Fix samtools version

* Update modules/nf-core/authentict/deam2cont/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/authentict/deam2cont/tests/main.nf.test

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/authentict/deam2cont/tests/main.nf.test

Co-authored-by: Simon Pearce <[email protected]>

---------

Co-authored-by: Simon Pearce <[email protected]>

* Migrate `BAMTOOLS/CONVERT` to nf-test (nf-core#7958)

* Migrate  to nf-test

* Update modules/nf-core/bamtools/convert/main.nf

Co-authored-by: Felix Lenner <[email protected]>

* Update modules/nf-core/bamtools/convert/tests/main.nf.test

Co-authored-by: Felix Lenner <[email protected]>

* Update modules/nf-core/bamtools/convert/tests/main.nf.test

Co-authored-by: Felix Lenner <[email protected]>

* Update modules/nf-core/bamtools/convert/tests/main.nf.test

Co-authored-by: Felix Lenner <[email protected]>

* Update variable names

* Fix spacing

---------

Co-authored-by: Felix Lenner <[email protected]>

* Updated deevariant to avoid failing nf-test (nf-core#7960)

Updated the main to avoid failing nf-test

* answer review Edo

* fixing logfile

* fixing variable name bug

* rebasing

* fixing variable name bug

* fixing variable name bug

---------

Co-authored-by: Bruno Ariano <[email protected]>
Co-authored-by: Sara Monzón <[email protected]>
Co-authored-by: Jim Downie <[email protected]>
Co-authored-by: Jonathan Manning <[email protected]>
Co-authored-by: Sofia Stamouli <[email protected]>
Co-authored-by: Lili Andersson-Li <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>
Co-authored-by: Angel Pizarro <[email protected]>
Co-authored-by: Angel Pizarro <[email protected]>
Co-authored-by: Zachary Foster <[email protected]>
Co-authored-by: Zachary Foster <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Krešimir Beštak <[email protected]>
Co-authored-by: robert-a-forsyth <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Nicolas Vannieuwkerke <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Igor Trujnara <[email protected]>
Co-authored-by: Maxime U Garcia <[email protected]>
Co-authored-by: John Orgera <[email protected]>
Co-authored-by: Usman Rashid <[email protected]>
Co-authored-by: Louis Le Nézet <[email protected]>
Co-authored-by: LouisLeNezet <[email protected]>
Co-authored-by: Felix Lenner <[email protected]>
Co-authored-by: Solenne Correard <[email protected]>
famosab pushed a commit to famosab/modules that referenced this pull request Jun 3, 2025
…er module, port to nf-test (nf-core#7847)

* Start updating FastK modules to allow conda

* Migrate all Merquryfk modules to nf-test

* Update to container with explicit R

* Fix container for FastK

* Start fixing fastk modules

* Fix FastK tests, add merquryfk/hapmaker module

* Fix linting for some merquryFK modules

* Fix merquryfk/merquryfk linting

* Fix linting for everything except hapmaker

* Fix snapshots?

* Update tests

* Fix tests pt 1000

* Sort fastk/merge test inputs to try and ensure repeatability

* Rename output channels to avoid linting error

* Fix hapmaker snapshot

* Harshill alignment

* Stub output format determined by args; add details to meta.yml files to disambiguate meta maps

* Remove def again from variables - causes error otherwise

* Fix Fastk/merge stub

* Update snapshot
famosab added a commit to famosab/modules that referenced this pull request Jun 3, 2025
* Module for PCA

* Module for PCA

* Module for PCA

* Module for PCA

* Module for PCA

* testing conda

* plinkpca

* Fixed ivar modules (nf-core#7868)

* fixed ivar variants module

* updated snapshot ivar variants because versions change

* fixed ivar consensus module

* simplified snapshot for consensus test, same as ivar variants module

* simplified snapshot for trim test, same as ivar variants module

* updated snapshot for ivar trim and consensus modules

* removed empty log file in ivar trim in snapshot

* updated ivar version to last one

* updated version also in conda env

* updated version also in conda env in ivar consensus and variants

* updated container version for ivar consensus and variants

* updated snapshots again

* Update FastK + MerquryFK versions + allow conda, add merquryfk/hapmaker module, port to nf-test (nf-core#7847)

* Start updating FastK modules to allow conda

* Migrate all Merquryfk modules to nf-test

* Update to container with explicit R

* Fix container for FastK

* Start fixing fastk modules

* Fix FastK tests, add merquryfk/hapmaker module

* Fix linting for some merquryFK modules

* Fix merquryfk/merquryfk linting

* Fix linting for everything except hapmaker

* Fix snapshots?

* Update tests

* Fix tests pt 1000

* Sort fastk/merge test inputs to try and ensure repeatability

* Rename output channels to avoid linting error

* Fix hapmaker snapshot

* Harshill alignment

* Stub output format determined by args; add details to meta.yml files to disambiguate meta maps

* Remove def again from variables - causes error otherwise

* Fix Fastk/merge stub

* Update snapshot

* Fix rnaseq preprocessing: don't trim with bad linting (nf-core#7881)

* Update versions for motus/preplong (nf-core#7854)

* Update versions for motus preplong

* Update modules/nf-core/motus/preplong/main.nf

Co-authored-by: Lili Andersson-Li <[email protected]>

* Versions

* Add tests for downloaddb

* Add snapshot

* Update to the latest motus merge

* Update motus merge

* Remove pytest

* Update pytest

* Update downloaddb

* Update modules/nf-core/motus/downloaddb/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/motus/preplong/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Add stub

* Add stub

---------

Co-authored-by: Lili Andersson-Li <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>

* Fixed conda channel order for fq module (nf-core#7871) (nf-core#7873)

* Fixed conda channel order for fq module (nf-core#7871)

By listing bioconda as the primary channel, the fq package can be installed and used in conda environments.

modified:   modules/nf-core/fq/generate/environment.yml
modified:   modules/nf-core/fq/lint/environment.yml
modified:   modules/nf-core/fq/subsample/environment.yml

* added channel order comment to avoid a regression

---------

Co-authored-by: Angel Pizarro <[email protected]>

* New module:  `khmer/trimlowabund` (nf-core#7806)

* add khmer/trimlowabund

* use evironment.yml

* chore(deps): update tj-actions/changed-files action to v46 (nf-core#7809)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Added coreograph nf-test (nf-core#7812)

coreograph nf-test

* Added ilastik/multicut nftest (nf-core#7811)

* main.nf changes

* finished test

* Update `graphtyper/vcfconcatenate`: Add batching to avoid long command line error (nf-core#7805)

add batching to vcfconcatenate to avoid long command line error

Co-authored-by: Zachary Foster <[email protected]>

* basicpy nf-test (nf-core#7772)

* basicpy nf-test

* removed leftover pytest

* separate output files

* updated meta

* separated outputs

* adapted test

* adapted inputs and snapshot

* removed pytest files

---------

Co-authored-by: Simon Pearce <[email protected]>

* Clair3 (nf-core#7765)

* Adds Clair3

* Removes TODOs and changes container urls

* Changes bash command

* Removes useless code lines

* Removes TODO statements

* Update meta.yml

adds more file info to meta.yml

* Update main.nf.test

removes TODO and updates clair3 model directory

* Update meta.yml
fixes doi link

* Add suggestions and changes data pulling

* Fix main.nf.test
adds correct structure to pass data to main

* fix yaml

* fix yaml
final one

* Update test snapshot

* Fix snapshot

* Fix tests

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Famke Bäuerle <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Famke Bäuerle <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Famke Bäuerle <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/clair3/meta.yml

Co-authored-by: Simon Pearce <[email protected]>

* Change meta description

* Update meta

* Update meta

* update screenshot

* Update modules/nf-core/clair3/main.nf

Co-authored-by: Simon Pearce <[email protected]>

---------

Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>

* chore(deps): update github actions (nf-core#7796)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Change file name for severus_somatic.vcf (nf-core#7814)

* Change file name for severus_somatic.vcf

* Update snapshot

* Update yaml

* Clean up hifiasm module + add bin file input (nf-core#7802)

* Tidy hifiasm model + update tests

* Update nf.test

* Fix linting

* Add fasta and PAF outputs to hifiasm; combine all bin files into a single output channel. Update documentation

* Improve descriptiveness of output channel names

* fix samtools/convert stub (nf-core#7816)

* add default memory if task.memory is not set

* Update modules/nf-core/khmer/trimlowabund/meta.yml

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/khmer/trimlowabund/meta.yml

Co-authored-by: Simon Pearce <[email protected]>

* Update `sourmash/compare`: Name output by prefix and update conda/docker (nf-core#7808)

* update sourmash/compare so output is named by prefix

* add stub to sourmash/sketch

* Update modules/nf-core/sourmash/sketch/tests/main.nf.test

Co-authored-by: Simon Pearce <[email protected]>

* move test for sourmash/gather from pytest to nf-test

* migrated sourmash taxannotate to nf-test

---------

Co-authored-by: Zachary Foster <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>

* add Subworkflow linting step to CI (nf-core#7835)

add swf linting step

* Add missing swf change detection (nf-core#7836)

* add swf linting step

* add missing change detection for subworkflows

* Add bedtools/shuffle module (nf-core#7803)

* Add bedtools/shuffle module

* Make linter happy

* Update test snapshots for bedtools/shuffle

* add new ARCHIVE_EXTRACT subworkflow (nf-core#7817)

* add new subworkflow

* rename

* fix tags

* add basic meta.yml

* better comments

* Update subworkflows/nf-core/archive_extract/main.nf

Co-authored-by: Simon Pearce <[email protected]>

---------

Co-authored-by: Simon Pearce <[email protected]>

* APPLYBQSR output line specificity  (nf-core#7818)

* updated output line and snap file

* linting fix in meta

* Trying out RunsOn runners (nf-core#7840)

* Trying out RunsOn runners

* try older image

* add debugging

* fix action

* pin setup-apptainer

* add gpu test

* fix usage syntax

* switch from docker_self_hosted to docker

* remove test comments

* Fix language server error in salmon/quant (nf-core#7843)

* New module: `busco/download` (nf-core#7788)

* add busco/download

* add author/maintainer

* update tests snap for new conda version

* revert to older conda version to match container versions

* update tests

* add stub

* removed unneeded code in stub

---------

Co-authored-by: Zachary Foster <[email protected]>

* Fix language server errors in arriba/arriba (nf-core#7845)

* name output by prefix

* set to process_medium

* check if input and output file are the same

* make sure regex matches only part of string

* Update modules/nf-core/khmer/trimlowabund/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/khmer/trimlowabund/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* apply changes made to file path handeling to stub

* Update modules/nf-core/khmer/trimlowabund/meta.yml

* Update modules/nf-core/khmer/trimlowabund/meta.yml

---------

Co-authored-by: Zachary Foster <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Krešimir Beštak <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>
Co-authored-by: robert-a-forsyth <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Jim Downie <[email protected]>
Co-authored-by: Nicolas Vannieuwkerke <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Igor Trujnara <[email protected]>
Co-authored-by: Maxime U Garcia <[email protected]>
Co-authored-by: John Orgera <[email protected]>

* Added cram output to samtools/fixmate (nf-core#7820)

* Added cram output to samtools/fixmate

* Fixed tag

* Fixed tag

* Fixed linting

* Updated onts

* Use nft-bam, update output glob

* Fixed meta.yml

---------

Co-authored-by: Simon Pearce <[email protected]>

* Migrate `ATAQV/MKARV` to nf-test (nf-core#7893)

Migrate to nf-test

Co-authored-by: LouisLeNezet <[email protected]>

* Added repeatmasker/repeatmasker (nf-core#7825)

* Added repeatmasker/repeatmasker

* Added onts

* Added mdust (nf-core#7823)

* Added mdust

* Responded to review

* Added agat/spfilterbyorfsize (nf-core#7822)

* Added agat/spfilterbyorfsize

* Added Gff tests

* Migrate `authentict/deam2cont` to nf-test (nf-core#7947)

* Update to nf-test

* Fix samtools version

* Update modules/nf-core/authentict/deam2cont/main.nf

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/authentict/deam2cont/tests/main.nf.test

Co-authored-by: Simon Pearce <[email protected]>

* Update modules/nf-core/authentict/deam2cont/tests/main.nf.test

Co-authored-by: Simon Pearce <[email protected]>

---------

Co-authored-by: Simon Pearce <[email protected]>

* Migrate `BAMTOOLS/CONVERT` to nf-test (nf-core#7958)

* Migrate  to nf-test

* Update modules/nf-core/bamtools/convert/main.nf

Co-authored-by: Felix Lenner <[email protected]>

* Update modules/nf-core/bamtools/convert/tests/main.nf.test

Co-authored-by: Felix Lenner <[email protected]>

* Update modules/nf-core/bamtools/convert/tests/main.nf.test

Co-authored-by: Felix Lenner <[email protected]>

* Update modules/nf-core/bamtools/convert/tests/main.nf.test

Co-authored-by: Felix Lenner <[email protected]>

* Update variable names

* Fix spacing

---------

Co-authored-by: Felix Lenner <[email protected]>

* Updated deevariant to avoid failing nf-test (nf-core#7960)

Updated the main to avoid failing nf-test

* answer review Edo

* fixing logfile

* fixing variable name bug

* rebasing

* fixing variable name bug

* fixing variable name bug

---------

Co-authored-by: Bruno Ariano <[email protected]>
Co-authored-by: Sara Monzón <[email protected]>
Co-authored-by: Jim Downie <[email protected]>
Co-authored-by: Jonathan Manning <[email protected]>
Co-authored-by: Sofia Stamouli <[email protected]>
Co-authored-by: Lili Andersson-Li <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>
Co-authored-by: Angel Pizarro <[email protected]>
Co-authored-by: Angel Pizarro <[email protected]>
Co-authored-by: Zachary Foster <[email protected]>
Co-authored-by: Zachary Foster <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Krešimir Beštak <[email protected]>
Co-authored-by: robert-a-forsyth <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Nicolas Vannieuwkerke <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Igor Trujnara <[email protected]>
Co-authored-by: Maxime U Garcia <[email protected]>
Co-authored-by: John Orgera <[email protected]>
Co-authored-by: Usman Rashid <[email protected]>
Co-authored-by: Louis Le Nézet <[email protected]>
Co-authored-by: LouisLeNezet <[email protected]>
Co-authored-by: Felix Lenner <[email protected]>
Co-authored-by: Solenne Correard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

4 participants