-
Notifications
You must be signed in to change notification settings - Fork 950
Fix fastp merge issue with subworkflow #7237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jfy133
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the save_merged schema addition is a bonus bug fix?
maxulysse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch
subworkflows/nf-core/fastq_qc_trim_filter_setstrandedness/meta.yml
Outdated
Show resolved
Hide resolved
subworkflows/nf-core/fastq_qc_trim_filter_setstrandedness/tests/main.nf.test
Outdated
Show resolved
Hide resolved
subworkflows/nf-core/fastq_qc_trim_filter_setstrandedness/tests/main.nf.test
Outdated
Show resolved
Hide resolved
Not sure what you're getting at.... |
This fixes an issue in
fastq_qc_trim_filter_setstrandednessinherited from its origin in nf-core/rnaseq. See nf-core/rnaseq#1452 for detail.PR checklist
Closes #XXX
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda