Skip to content

Conversation

@pinin4fjords
Copy link
Member

This fixes an issue in fastq_qc_trim_filter_setstrandedness inherited from its origin in nf-core/rnaseq. See nf-core/rnaseq#1452 for detail.

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

jfy133
jfy133 previously approved these changes Dec 17, 2024
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the save_merged schema addition is a bonus bug fix?

maxulysse
maxulysse previously approved these changes Dec 17, 2024
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@pinin4fjords pinin4fjords dismissed stale reviews from maxulysse and jfy133 via 85a593c December 17, 2024 17:05
@pinin4fjords
Copy link
Member Author

Assuming the save_merged schema addition is a bonus bug fix?

Not sure what you're getting at....

@pinin4fjords pinin4fjords added this pull request to the merge queue Dec 17, 2024
Merged via the queue into master with commit 8a01490 Dec 17, 2024
27 checks passed
@pinin4fjords pinin4fjords deleted the fix_fastp_merge branch December 17, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants