Skip to content

Update to topics getorganelle/*#11561

Open
LouisLeNezet wants to merge 1 commit intonf-core:masterfrom
LouisLeNezet:getorganelle
Open

Update to topics getorganelle/*#11561
LouisLeNezet wants to merge 1 commit intonf-core:masterfrom
LouisLeNezet:getorganelle

Conversation

@LouisLeNezet
Copy link
Copy Markdown
Contributor

PR checklist

Closes #11503
Closes #11504

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@LouisLeNezet LouisLeNezet self-assigned this May 7, 2026
Copy link
Copy Markdown
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you downgrading fromreads to 1.7.7.0, rather than upgrading config to 1.7.7.1?

Comment on lines +25 to +34
{
def stable_name = getAllFilesFromDir(process.out.db[0][1].toString(), include:['*', '**/*'])
def stable_content = getAllFilesFromDir(process.out.db[0][1].toString(), include:["**/VERSION", "**/animal_mt.fasta"])

assert snapshot(
stable_name*.name.sort(),
stable_content,
process.out.findAll { key, val -> key.startsWith('versions') }
).match()
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has lost its indentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migration to topic channels: getorganelle/fromreads Migration to topic channels: getorganelle/config

2 participants