Skip to content

nanofilt topic channel migration#11534

Merged
FernandoDuarteF merged 5 commits intonf-core:masterfrom
Eco-Flow:topic_nanofilt
May 7, 2026
Merged

nanofilt topic channel migration#11534
FernandoDuarteF merged 5 commits intonf-core:masterfrom
Eco-Flow:topic_nanofilt

Conversation

@FernandoDuarteF
Copy link
Copy Markdown
Contributor

@FernandoDuarteF FernandoDuarteF commented May 5, 2026

PR checklist

Closes #11528

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Comments

I also added a config to filter the test reads based on length, since before there was no difference between input and output reads.

@SPPearce SPPearce added this pull request to the merge queue May 6, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 6, 2026
@FernandoDuarteF FernandoDuarteF enabled auto-merge May 6, 2026 13:55
@FernandoDuarteF FernandoDuarteF added this pull request to the merge queue May 7, 2026
Merged via the queue into nf-core:master with commit f100b31 May 7, 2026
23 checks passed
@FernandoDuarteF FernandoDuarteF deleted the topic_nanofilt branch May 7, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migration to topic channel: nanofilt

2 participants