Skip to content

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Apr 11, 2025

based on #207

  • Waiting for docker build
  • Testing fresh install
  • Testing upgrade
  • Request publish
  • Merge

@blizzz blizzz force-pushed the rel/nc30 branch 8 times, most recently from 0b16801 to 9ea6063 Compare April 29, 2025 14:00
@blizzz
Copy link
Member Author

blizzz commented May 21, 2025

Downstream found an update issue, hence the delay.

Signed-off-by: Arthur Schiwon <[email protected]>
@palstek
Copy link

palstek commented Jun 4, 2025

Anything I can do to accelerate the merge process?

Is there a beta app channel available to test this PR?

Signed-off-by: Arthur Schiwon <[email protected]>
@jfk22
Copy link

jfk22 commented Jul 30, 2025

Any ETA for the release of NC30 for UCS?

@blizzz
Copy link
Member Author

blizzz commented Sep 8, 2025

Right now there is a failing test case on a re-installation on 5.0. That`s the blocker, and since last time my focus was unfortunately elsewhere.

The background is: when the same Nextcloud version was installed, removed and is installed again, then user_saml is not being fetched again from the appstore. It is in a Schroedinger state:

image

And then the joinscript fails, because it expects user_saml to be enabled.

Maybe this is a regression in 30 (or maybe up to 30.0.10, the last build i just investigated again). I suspect so. And it would also leave other apps uninstalled that were previously enabled. I'll continue the investigation here (but you can beat me to it and post results here but we may risk to duplicate work).

I also wished to get back to this earlier again, sorry for the delay.

@ateuber
Copy link

ateuber commented Sep 10, 2025

@blizzz Not sure if it relevant here, but I had a problem with missing apps in 2023 and fixed it like this:

univention-app shell nextcloud sudo -u www-data php /var/www/html/occ config:list | jq '.apps | with_entries(select(.value.enabled == "yes")) | keys' | tail -n +2 | head -n -1 | sed 's/ //g' | sed 's/"//g' | sed 's/,//g' > appinconfig
univention-app shell nextcloud sudo -u www-data php /var/www/html/occ app:list --output=json | jq '.enabled' | jq 'keys' | tail -n +2 | head -n -1 | sed 's/ //g' | sed 's/"//g' | sed 's/,//g' > appinappslist
comm -13 appinappslist appinconfig |  while read line ; do univention-app shell nextcloud sudo -u www-data php /var/www/html/occ app:disable $line ; univention-app shell nextcloud sudo -u www-data php /var/www/html/occ app:enable $line ; done

So maybe user_saml is disabled but still active in the config?

@blizzz
Copy link
Member Author

blizzz commented Sep 11, 2025

@blizzz Not sure if it relevant here, but I had a problem with missing apps in 2023 and fixed it like this:

univention-app shell nextcloud sudo -u www-data php /var/www/html/occ config:list | jq '.apps | with_entries(select(.value.enabled == "yes")) | keys' | tail -n +2 | head -n -1 | sed 's/ //g' | sed 's/"//g' | sed 's/,//g' > appinconfig
univention-app shell nextcloud sudo -u www-data php /var/www/html/occ app:list --output=json | jq '.enabled' | jq 'keys' | tail -n +2 | head -n -1 | sed 's/ //g' | sed 's/"//g' | sed 's/,//g' > appinappslist
comm -13 appinappslist appinconfig |  while read line ; do univention-app shell nextcloud sudo -u www-data php /var/www/html/occ app:disable $line ; univention-app shell nextcloud sudo -u www-data php /var/www/html/occ app:enable $line ; done

So maybe user_saml is disabled but still active in the config?

The difference to NC 30 is nextcloud/server#44025 and with this the definition of whether an app is installed has changed. In 29, it was the presence of an app-path, in 30 it is the enabled state:

image

and in 30:

image

@blizzz
Copy link
Member Author

blizzz commented Sep 11, 2025

To clarify on before, the issue that after an uninstall, and reinstall, apps are enabled by the old configuration, but not installed yet.

The code diverges further on master (nextcloud/server#49648, left a comment at https://github.com/nextcloud/server/pull/49648/files#r2341962849), and this is such an edge case, that it is very weird to consider it there again. I have a working patch against 30, considering to ship it here only and unlock the release, and think about something else for future releases.

@blizzz
Copy link
Member Author

blizzz commented Sep 12, 2025

I bumped to latest 30 and applied most recent state of nextcloud/server#55065 as a patch (commit nextcloud/server@ac6653e).

Rebuilding takes today unfortunately, slow download server here, acting up github services there, … 😕

@blizzz
Copy link
Member Author

blizzz commented Sep 12, 2025

… seems successful. Wrapping up and submitting…

Update
done. Now the ball is on Univention's side.

- includes nextcloud/server#55065

Signed-off-by: Arthur Schiwon <[email protected]>
@palstek

This comment was marked as duplicate.

@blizzz blizzz merged commit 31bf0ff into master Oct 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants