[stable30] fix(Apps): fix install command check on existing apps

[blizzz]

Summary

Currently, enabled apps are returned, whether they are installed or not. This is a behavioral breaking change compared to 29.

Based this now on 30 for nextcloud/univention-app#208, and I am not sure this is what we really want in server (cf. my comment at https://github.com/nextcloud/server/pull/49648/files#r2341962849).

If so, I'd do a new PR based on master, which has diverges further.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[blizzz]

otoh not sure whether this approach might cause other side effects, as getInstalledAppsValues worked like this in 29 already. I guess I am going to change it to apply it on install command level again, but this will involve legacy API again, so even less acceptable for inclusion. Alternatively extending API with returning all installed apps with their paths… would be separate effort aimed at master then.

UPDATE:
For reference, previous, now dropped, commits I talked about were:

• fd3e612
• 8e06240

[come-nc]

I think this is not a good change.

To install an application manually, you put it in the apps folder and then run app:install, no? With this change it would not be possible anymore?

[blizzz]

To install an application manually, you put it in the apps folder and then run app:install, no? With this change it would not be possible anymore?

No, you run occ:enable. Which installs it from appstore, if it is not present.