Add benchmark tool for the recording server#9120
Merged
nickvergessen merged 8 commits intomasterfrom Mar 22, 2023
Merged
Conversation
Member
Author
|
/backport to stable26 |
5 tasks
Member
Done, rebase? |
danxuliu
force-pushed
the
add-benchmark-tool-for-the-recording-server
branch
from
8232bc4 to
726eb4a
Compare
Rather than providing some values and then composing the final name from them now the sink name is explicitly provided. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Rather than providing some values and then composing the final name from them now the recorder log name is explicitly provided. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
This will make easier to override the values set in the configuration for specific runs. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
The benchmark tool can be used to check the resources needed by the recorder process with different configurations, as well as to verify the quality of the recorded file. Unlike a real call recording the benchmark helper does not launch a browser and joins an actual call; instead a video file is played. Therefore it can not be used to check the whole usage of resources during a call recording, but only the resources used by the recorder itself. On the other hand, playing a video file eases performing the tests, as it does not require an actual call to be running, and also helps to compare the quality between different configurations, as they can all be based on the same input. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
add-benchmark-tool-for-the-recording-server
branch
from
726eb4a to
a1d35cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #9119
Feel free to directly review/merge this one and skip #9119