Add configuration options for FFmpeg#9119
Merged
nickvergessen merged 3 commits intomasterfrom Mar 21, 2023
Merged
Conversation
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
VP8 encoder now uses the "Constant quality mode" to ensure that every frame gets the needed bitrate to achieve certain quality level rather than forcing the whole stream to have an average bitrate. The maximum bitrate is set to 1Mbit/s, which should be enough to get clear images even with FullHD screen shares (although this might still compress some screen shares, as the default bitrate for screen shares in the HPB is set to 2Mbit/s, but it should be enough for typical screen shares of slides). Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Member
Author
|
/backport to stable26 |
nickvergessen
approved these changes
Mar 21, 2023
Member
|
Much better :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides making the encoders and the extension configurable this also increases the default quality for videos and serves as the basis to add a benchmark tool.
In the future it could be better to make it configurable as well by backend, given that each backend can use different resolutions and thus might not require the same quality, but for now this should be enough.