Fix duplicated registration of audio encoder#6103
Merged
nickvergessen merged 1 commit intomasterfrom Aug 20, 2021
Merged
Conversation
The audio encoder is initialized when the AudioRecorder component is mounted, and the store keeps track of whether the audio encoder was already initialized to not do it again. However, the audio encoder was also unconditionally registered in the main components of the main and sidebar Talk UIs, which caused a duplicated registration when the audio encoder was initialized (as the store did not "know" that it was already registered). Due to all this the unconditional registration is removed (which also avoids registering the audio encoder when it will not be needed, like when the current user is a guest without upload permissions). Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Member
Author
|
/backport to stable22.1 |
marcoambrosini
approved these changes
Aug 18, 2021
Member
marcoambrosini
left a comment
marcoambrosini
left a comment
There was a problem hiding this comment.
Thanks for cleaning up after me :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The audio encoder is initialized when the AudioRecorder component is mounted, and the store keeps track of whether the audio encoder was already initialized to not do it again.
However, the audio encoder was also unconditionally registered in the main components of the main and sidebar Talk UIs (ironically to also fix the duplicated registration :-P ), which caused a duplicated registration when the audio encoder was initialized (as the store did not "know" that it was already registered).
Due to all this the unconditional registration is removed (which also avoids registering the audio encoder when it will not be needed, like when the current user is a guest without upload permissions).