Wait for the wav encoder to be initialized before allowing recordings#5970
Merged
nickvergessen merged 1 commit intomasterfrom Jul 14, 2021
Conversation
PVince81
reviewed
Jul 7, 2021
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
marcoambrosini
force-pushed
the
bugfix/noid/do-not-allow-recording-until-mediaencoder-is-initialized
branch
from
907b57c to
24e3f6f
Compare
PVince81
approved these changes
Jul 14, 2021
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍 approach looks good, see minor comment
| import { register } from 'extendable-media-recorder' | ||
| import { connect } from 'extendable-media-recorder-wav-encoder' | ||
|
|
||
| const state = () => ({ |
Member
There was a problem hiding this comment.
am wondering if we need a generic store category for that.
having a specific store submodule just for this feels a bit overkill
Member
Author
There was a problem hiding this comment.
What do you have in mind?
Member
|
some weird unrelated errors: |
Member
Author
|
/backport to stable22.1 |
nickvergessen
deleted the
bugfix/noid/do-not-allow-recording-until-mediaencoder-is-initialized
branch
Member
|
/backport to stable22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marco Ambrosini marcoambrosini@pm.me