feat(dav): allow extending propfind properties via event #57914
+71
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminfrueh
requested review from
Altahrim and
icewind1991
and removed request for
a team
benjaminfrueh
force-pushed
the
feat/extendable-propfind
branch
from
5471dd1 to
5f63dc5
Compare
juliusknorr
reviewed
Jan 29, 2026
juliusknorr
reviewed
Jan 29, 2026
juliusknorr
reviewed
Jan 29, 2026
| /** | ||
| * @since 32.0.0 | ||
| */ | ||
| class BeforePropfindEvent extends Event { |
Member
There was a problem hiding this comment.
Not entirely sure about naming, BeforeRemoteProfindEvent may indicate a bit more that it is about outgoing propfind requests, not to be confused with clients requesting the webdav endpoints.
Contributor
Author
There was a problem hiding this comment.
Thanks for this good suggestion, I renamed the event to BeforeRemotePropfindEvent
juliusknorr
approved these changes
Jan 29, 2026
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Some minor comments, but the approach is fine I think 👍
Member
|
phpunit failures do not seem related, but autoloader needs to be updated with the new class |
benjaminfrueh
force-pushed
the
feat/extendable-propfind
branch
2 times, most recently
from
38ad2b0 to
82179a8
Compare
Signed-off-by: Benjamin Frueh <[email protected]> Update lib/public/Files/Events/BeforePropfindEvent.php Co-authored-by: Julius Knorr <[email protected]> Signed-off-by: Benjamin Früh <[email protected]> Update lib/public/Files/Events/BeforePropfindEvent.php Co-authored-by: Julius Knorr <[email protected]> Signed-off-by: Benjamin Früh <[email protected]> refactor: rename BeforePropfindEvent to BeforeRemotePropfindEvent Signed-off-by: Benjamin Frueh <[email protected]> chore: update composer autoloader for new event class Signed-off-by: Benjamin Frueh <[email protected]>
benjaminfrueh
force-pushed
the
feat/extendable-propfind
branch
from
82179a8 to
2ec4d96
Compare
Member
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes the list of WebDAV properties requested in PROPFIND calls extendable via
BeforePropfindEvent.This was implemented to enable the files_lock app to add lock properties for federation.
Changes
BeforePropfindEventinDAV::getPropfindProperties()getPropfindPropertyValue()method to access requested propertiesRequired for nextcloud/files_lock#954