Skip to content

feat: add federated file locking #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
benjaminfrueh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add federated file locking #954

benjaminfrueh wants to merge 1 commit into from
+120 −21

Conversation

@benjaminfrueh
Copy link

@benjaminfrueh benjaminfrueh commented Jan 7, 2026 •
edited
Loading

Summary

Implements federated file locking, allowing locks to propagate between servers.

Changes

- Added OCS api endpoint to check locks by share token

  • Request locks using webdav propfind
  • Check remote locks before allowing file operations
  • Show hostname in lock display for remote locks (e.g. [email protected])

Fixes #896

Requires nextcloud/server#57914

@benjaminfrueh benjaminfrueh added enhancement New feature or request 3. to review labels Jan 7, 2026
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Jan 7, 2026
@benjaminfrueh benjaminfrueh force-pushed the feat/federated-file-locking branch 2 times, most recently from 421fdea to 1fbdd05 Compare January 7, 2026 20:40
juliusknorr
juliusknorr reviewed Jan 8, 2026
View reviewed changes
juliusknorr
juliusknorr reviewed Jan 8, 2026
View reviewed changes
juliusknorr
juliusknorr reviewed Jan 8, 2026
View reviewed changes
@benjaminfrueh benjaminfrueh moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Office team Jan 8, 2026
@max-nextcloud max-nextcloud removed their request for review January 8, 2026 19:21
@max-nextcloud
Copy link
Collaborator

max-nextcloud commented Jan 8, 2026

unassigning myself as a reviewer as I do not have time to look into this.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2026

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@juliusknorr juliusknorr requested a review from samin-z January 22, 2026 08:52
samin-z
samin-z reviewed Jan 22, 2026
View reviewed changes
@benjaminfrueh benjaminfrueh marked this pull request as draft January 28, 2026 23:58
@benjaminfrueh benjaminfrueh force-pushed the feat/federated-file-locking branch from 17a6953 to ad0002b Compare January 29, 2026 16:03
@benjaminfrueh benjaminfrueh marked this pull request as ready for review January 29, 2026 16:05
@benjaminfrueh benjaminfrueh moved this from 🏗️ In progress to 👀 In review in 📝 Office team Jan 29, 2026
@benjaminfrueh benjaminfrueh force-pushed the feat/federated-file-locking branch 2 times, most recently from f69eed0 to 2029c30 Compare January 29, 2026 16:23
@juliusknorr juliusknorr mentioned this pull request Jan 29, 2026
Open
juliusknorr
juliusknorr reviewed Jan 29, 2026
View reviewed changes
juliusknorr
juliusknorr reviewed Jan 29, 2026
View reviewed changes
juliusknorr
juliusknorr reviewed Jan 29, 2026
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

@benjaminfrueh
Copy link
Author

benjaminfrueh commented Jan 29, 2026

Some minor comments

Thank you for the feedback, I made changes accordingly.

@benjaminfrueh benjaminfrueh force-pushed the feat/federated-file-locking branch 2 times, most recently from b891482 to 3cdea3e Compare January 29, 2026 19:08
@benjaminfrueh
Copy link
Author

benjaminfrueh commented Jan 29, 2026

/backport to stable33

@benjaminfrueh
Copy link
Author

benjaminfrueh commented Jan 29, 2026

/backport to stable32

@benjaminfrueh @juliusknorr
feat: add federated file locking
b826403 
Signed-off-by: Benjamin Frueh <[email protected]>

fix: use ocp methods instead of sql queries and add path param for folder support

Signed-off-by: Benjamin Frueh <[email protected]>

feat: request federated locks using webdav propfind

Signed-off-by: Benjamin Frueh <[email protected]>

Update lib/Service/LockService.php

Co-authored-by: Julius Knorr <[email protected]>
Signed-off-by: Benjamin Früh <[email protected]>

refactor: rename propfind event and use first userfolder node directly

Signed-off-by: Benjamin Frueh <[email protected]>

Apply suggestions from code review

Co-authored-by: Julius Knorr <[email protected]>
Signed-off-by: Benjamin Früh <[email protected]>
@benjaminfrueh benjaminfrueh force-pushed the feat/federated-file-locking branch from 3cdea3e to b826403 Compare January 30, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@samin-z samin-z Awaiting requested review from samin-z

Assignees

No one assigned

Labels

3. to review enhancement New feature or request feedback-requested

Projects

📝 Office team
Status: 👀 In review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Temporary files lock & federation

5 participants

@benjaminfrueh @max-nextcloud @juliusknorr @samin-z