Skip to content

[stable-3.6] fix renaming of folders with a deep hierarchy inside them#5186

Merged
mgallien merged 8 commits into
stable-3.6from
backport/5182/stable-3.6
Nov 24, 2022
Merged

[stable-3.6] fix renaming of folders with a deep hierarchy inside them#5186
mgallien merged 8 commits into
stable-3.6from
backport/5182/stable-3.6

Conversation

@backportbot-nextcloud

@backportbot-nextcloud backportbot-nextcloud Bot commented Nov 18, 2022

Copy link
Copy Markdown
  • ⚠️ This backport had conflicts and is incomplete

backport of #5182

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
currently broken test as we miss to rename recursively

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
propagate renaming of parent folders to child recursively

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
use QString::arg with multiple parameters because that is faster

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the backport/5182/stable-3.6 branch from 4381383 to 045159a Compare November 24, 2022 11:08
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot

Copy link
Copy Markdown

AppImage file: nextcloud-PR-5186-020e211b723db01b1f5ef6e7c3e311d8bfa69fb6-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 742ecd6 into stable-3.6 Nov 24, 2022
@mgallien mgallien deleted the backport/5182/stable-3.6 branch November 24, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants