fix renaming of folders with a deep hierarchy inside them#5182
Merged
Conversation
mgallien
changed the title
claucambra
approved these changes
Nov 16, 2022
mgallien
force-pushed
the
bugfix/fixRenameDeepHierarchy
branch
from
30badcc to
7a1c47d
Compare
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
currently broken test as we miss to rename recursively Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
propagate renaming of parent folders to child recursively Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
use QString::arg with multiple parameters because that is faster Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
bugfix/fixRenameDeepHierarchy
branch
from
7a1c47d to
2742c6a
Compare
Collaborator
Author
|
@claucambra thanks for initial review, can you have another look at it ? |
claucambra
approved these changes
Nov 17, 2022
claucambra
left a comment
claucambra
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, I provided some nitpicks below
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5182 +/- ##
==========================================
+ Coverage 57.59% 57.71% +0.11%
==========================================
Files 138 138
Lines 17399 17441 +42
==========================================
+ Hits 10021 10066 +45
+ Misses 7378 7375 -3
|
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
|
SonarCloud Quality Gate failed. |
|
AppImage file: nextcloud-PR-5182-ad32bc7ce55c01e17f7063860a4dcd6f9205b419-x86_64.AppImage |
Collaborator
Author
|
/backport to stable-3.6 |
1 task
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently broken test as we miss to rename recursively
Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com