Improve "pretty user name"-related strings, display in webflow credentials#5013
Merged
Conversation
mgallien
requested changes
Oct 6, 2022
claucambra
force-pushed
the
bugfix/webflow-user-strings
branch
from
35f3d46 to
78184f0
Compare
claucambra
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5013 +/- ##
==========================================
- Coverage 57.35% 57.30% -0.05%
==========================================
Files 138 138
Lines 17391 17402 +11
==========================================
- Hits 9974 9972 -2
- Misses 7417 7430 +13
|
mgallien
reviewed
Oct 10, 2022
claucambra
changed the title
claucambra
force-pushed
the
bugfix/webflow-user-strings
branch
from
77dbc15 to
0b9267c
Compare
claucambra
changed the title
mgallien
force-pushed
the
bugfix/webflow-user-strings
branch
from
0b9267c to
82be953
Compare
mgallien
approved these changes
Oct 19, 2022
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
claucambra
force-pushed
the
bugfix/webflow-user-strings
branch
from
82be953 to
0bce174
Compare
|
AppImage file: nextcloud-PR-5013-0bce17425b5f50fdad871cf1277a058a816b39d2-x86_64.AppImage |
|
SonarCloud Quality Gate failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Claudio Cambra claudio.cambra@gmail.com