Use prettyName more widely, instead of duplicating fallback string code

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

Author: claucambra

src/gui/accountsettings.cpp

@@ -1110,10 +1110,7 @@ void AccountSettings::slotAccountStateChanged()
                                        Utility::escape(safeUrl.toString()));
         QString serverWithUser = server;
         if (AbstractCredentials *cred = account->credentials()) {
-            QString user = account->davDisplayName();
-            if (user.isEmpty()) {
-                user = cred->user();
-            }
+            QString user = account->prettyName();
             serverWithUser = tr("%1 as %2").arg(server, Utility::escape(user));
         }
 

src/gui/settingsdialog.cpp

@@ -57,10 +57,7 @@ const float buttonSizeRatio = 1.618f; // golden ratio
  */
 QString shortDisplayNameForSettings(OCC::Account *account, int width)
 {
-    QString user = account->davDisplayName();
-    if (user.isEmpty()) {
-        user = account->credentials()->user();
-    }
+    QString user = account->prettyName();
     QString host = account->url().host();
     int port = account->url().port();
     if (port > 0 && port != 80 && port != 443) {

src/gui/tray/usermodel.cpp

@@ -733,12 +733,7 @@ void User::logout() const
 
 QString User::name() const
 {
-    // If davDisplayName is empty (can be several reasons, simplest is missing login at startup), fall back to username
-    QString name = _account->account()->davDisplayName();
-    if (name == "") {
-        name = _account->account()->credentials()->user();
-    }
-    return name;
+    return _account->account()->prettyName();
 }
 
 QString User::server(bool shortened) const