-
Notifications
You must be signed in to change notification settings - Fork 96
Properly align AppNavigationToggle with first navigation item #3278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2a37e14 to
c0c9f50
Compare
|
I'm not able to see a difference between the before and after screenshot |
Have a close look on the navigation toggle, on the |
|
@GretaD please test how this aligns with the Groupware apps |
c0c9f50 to
6b22cef
Compare
|
This issue has been here for a while, talk shift it manually, photos too, having a proper standard would indeed be nice yeah :) |
6b22cef to
ec80e57
Compare
|
Rebased this and used a css variable for easier adjustment as wished. I think with current master being version 8 for NC28 we give apps enough time to adjust. |
ec80e57 to
6f22b6c
Compare
6f22b6c to
392ddec
Compare
|
Ping? |
…avigation item Signed-off-by: Ferdinand Thiessen <[email protected]>
392ddec to
e6c0894
Compare



Currently the toggle is set at
4pxwhile the app navigation items are placed at8px(using that variable), this looks slightly displaced.So this PR moves the padding calculation into a variable and uses the variable for the toggle (besides the navigation items).
Before / Currently:

After / This PR:
