feat: allow users to pass custom timestamps to from_numpy#941
Open
muvva-krishna wants to merge 2 commits intoneuroinformatics-unit:mainfrom
Open
feat: allow users to pass custom timestamps to from_numpy#941muvva-krishna wants to merge 2 commits intoneuroinformatics-unit:mainfrom
muvva-krishna wants to merge 2 commits intoneuroinformatics-unit:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #473
Allow users to pass a
timestampsarray tofrom_numpy()instead ofderiving time coordinates from
fps.Changes:
timestampsfield to_BaseDatasetInputsinvalidators/datasets.pyValidPosesInputs.to_dataset()before buildingthe xarray Dataset (raises
ValueErrorif length mismatchesn_frames)timestampsthroughload_poses.from_numpy()intoValidPosesInputsTests:
test_from_numpy_with_custom_timestamps: verifies irregular timestampsare set correctly as the time coordinate
test_from_numpy_timestamps_wrong_length_raises: verifiesValueErroris raised when timestamp length does not match number of frames