Modified .call()/.construct() API
#816
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(neon): Add `JoinHandle` as a result of `Channel::send`
Initial implementation for JsPromise and TaskBuilder
…a panic * Catches panics and converts to uncaughtException * Throws uncaughtException if throwing * Passes opaque exceptions through as JsBox
fix(neon): Fix undefined behavior in channel callbacks when there is a panic
Catch panics in tasks and convert to rejections
…nstead of `IntoIterator`.
Collaborator
Author
|
Grrr, why did this think it was a PR against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR experiments with a modified
.call()and.construct()API forJsFunction, based on the ideas we came up with in #796 as well as the idea of overloading result types to make downcasting more concise and ergonomic. The changes include:Argumentstrait instead ofIntoIterator, which still works forVecand arrays but also heterogeneous tuples.exec()method for discarding the result when it's not neededThis generally leads to more concise and readable code. But it has a few downsides:
[]) tend to lead to inference errors where empty tuples (()) usually work, could both be confusing especially to newer Rust programmers.cx, whereas the method chaining approach in Arguments builder API #796 circumvents this issue._) to be passed after the result type.JsValue, may not be able to be made zero cost. (But this is probably most often needed for discarding the result, in which case.exec()avoids the downcast overhead.)I wanted to implement this before we finalize the builder APIs, so that we can consider the complete set of function call APIs holistically.