Catch panics in tasks and convert to rejections #813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The changes aren't quite as intimidating when excluding tests. 498 additions, 334 deletions and about half of those are moving lines from one file to another. |
dherman
requested changes
Oct 27, 2021
Collaborator
dherman
left a comment
dherman
left a comment
There was a problem hiding this comment.
Looks good! Just a few suggestions for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #808 and applies similar logic to tasks that use promises.
It also makes changes to match the latest neon-bindings/rfcs#35:
Deferred::settle_withis removed. Manually resolving aDeferredis considered low level. Adding a helper is unnecessary.Channel::settle_withtoDeferred::settle_with. Now that there is room onDeferred, it reads more clearly here.