add support for fixed size array of any type#3
Closed
defactojob wants to merge 1 commit intonear:masterfrom
Closed
add support for fixed size array of any type#3defactojob wants to merge 1 commit intonear:masterfrom
defactojob wants to merge 1 commit intonear:masterfrom
Conversation
ailisp
reviewed
Jan 21, 2021
Member
ailisp
left a comment
There was a problem hiding this comment.
Thanks. Code looks good, can you write tests to 1) successfully deserialize and serialize a fix size array; 2) failed to readArray when len incorrect; 3) failed to writeArray when len incorrect
|
@ailisp @defactojob or @mehtaphysical there is any update? I want to send a list of let parsed_bundles = bundles.split(";").map(Number);
let bundles_prices = [];
for (let i = 0; i < 12; i++) {
bundles_prices.push(new BN(sol_to_lamports(parsed_bundles[i]), 16) || new BN(0, 16));
}Error: Any suggestion or help? Thanks! |
|
When you say of any type, does that include f64? |
Contributor
|
Closing PR as it is not compatible with the new code, please resolve conflicts if still relevant and open again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.