add fixed array serialization/deserialization#27
Merged
mehtaphysical merged 2 commits intomasterfrom Jul 22, 2021
Merged
Conversation
Contributor
Author
|
didn't notice there is already #3 |
ailisp
reviewed
Jul 22, 2021
| expect(buf).toEqual(Buffer.from([5, 0, 0, 0, 104, 101, 108, 108, 111, 5, 0, 0, 0, 119, 111, 114, 108, 100])); | ||
| expect(deserializedValue.a).toEqual(['hello', 'world']); | ||
| }); | ||
|
|
Member
There was a problem hiding this comment.
This test looks nice. I think we also need a test to test error to serilaize/deserialize when given array has a different array in schema.
ailisp
approved these changes
Jul 22, 2021
Member
ailisp
left a comment
ailisp
left a comment
There was a problem hiding this comment.
Looks good. Seems CI is broken by fossa. Does your local yarn test work?
volovyks
approved these changes
Jul 22, 2021
Contributor
Author
|
added tests for error cases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26.
This adds serialization for fixed arrays.