Skip to content
Merged
Show file tree
Hide file tree
Changes from 38 commits
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
f853ccb
Added led-blinker workflow for aarch64-linux platform
moisesmata May 29, 2025
b542ecb
Update runner label
moisesmata May 29, 2025
ecd1bf9
Added Tags to RPI self hosted workflows, sparse-checkout-cone-mode false
moisesmata May 29, 2025
4cd3832
Add subtopologies to Svc/ restructing of Ref to include CDH subtopology
moisesmata Jun 4, 2025
5625dfe
Merge branch 'nasa:devel' into add-subtopologies
moisesmata Jun 4, 2025
8cc262d
CDHCore Subtopology added under Svc and integrated into Ref
moisesmata Jun 5, 2025
3e165b1
Merge branch 'add-subtopologies' of https://github.com/moisesmata/fpr…
moisesmata Jun 5, 2025
7bdd72a
Health instance within CDHCore references CDHCoreConfig for queue size
moisesmata Jun 5, 2025
99f9dee
Update metadata
moisesmata Jun 5, 2025
55bd645
Added AssertFatalAdapter Version PassiveTextLogger to Subtopology, co…
moisesmata Jun 6, 2025
747d8de
Comms subtopology without cmdSeq created, integrated in Ref
moisesmata Jun 6, 2025
06802d3
Added cmdSeq to Comms Subtopology, integrated into Ref
moisesmata Jun 6, 2025
102bfc2
Add FileHandling Subtopology, initial structure
moisesmata Jun 6, 2025
910c775
Fixed Spelling, Flie -> File
moisesmata Jun 7, 2025
7a1d68c
Update metadata
moisesmata Jun 7, 2025
954f32c
Added working FileHandling, DataProducts subtopology, integrated into…
moisesmata Jun 9, 2025
d39aa5d
prmDb part of FileHandling, fatalHandler part of CDHCore
moisesmata Jun 9, 2025
84c922d
Update metadata
moisesmata Jun 9, 2025
c05a942
Update comment for clarity
moisesmata Jun 9, 2025
b0deda5
Initial move to phasing components
moisesmata Jun 9, 2025
db052fb
Merge branch 'add-subtopologies' of https://github.com/moisesmata/fpr…
moisesmata Jun 10, 2025
5dc46cf
Fixing Phasing: Adding initial Phasing for CDHCore, DataProducts, Fil…
moisesmata Jun 10, 2025
03f158c
Renaming topologydefs.hpp, phasing fully working on all four subtopol…
moisesmata Jun 10, 2025
3bbc055
Cleanup with Ports_ComPacketQueue, definition only in Comms.fpp now
moisesmata Jun 11, 2025
f6f5737
Base project with all 4 subtopologies, integrated into Ref, and passi…
moisesmata Jun 16, 2025
1e70dcd
Initial Commit with all Subtopologies in Svc/Subtopologies
moisesmata Jun 17, 2025
1984f49
Merge branch 'add-subtopologies' into add/subtopologies
moisesmata Jun 17, 2025
20e46dc
Merge pull request #7 from moisesmata/add/subtopologies
moisesmata Jun 17, 2025
797717f
Added posixtime back in to Ref Deployment (Accidentally Deleted)
moisesmata Jun 17, 2025
bcbeeef
Merge branch 'nasa:devel' into add-subtopologies
moisesmata Jun 18, 2025
a78cbee
Updates to match new subtopology structure, integrate CCSDS into Ref
moisesmata Jun 18, 2025
8fd198b
Changes to CommCCSDS that go with last changes
moisesmata Jun 18, 2025
97d50d7
Merge branch 'nasa:devel' into add-subtopologies
moisesmata Jun 18, 2025
3900bc0
Standardize subtopology structure and naming to PascalCase
moisesmata Jun 18, 2025
540698c
Merge branch 'add-subtopologies' into temp
moisesmata Jun 18, 2025
535620b
Merge pull request #9 from moisesmata/temp
moisesmata Jun 18, 2025
0c8ee99
Namespace fixe for ComFprime
moisesmata Jun 18, 2025
7c0b08e
CDHCore->Cdhcore for consistency
moisesmata Jun 18, 2025
01849be
Rename CDHCore to CdhCore for consistency
moisesmata Jun 19, 2025
eb7a453
Update metadata
moisesmata Jun 19, 2025
05a5c8f
Reorder on teardown phases for Com Subtopolgies
moisesmata Jun 19, 2025
f00ecc5
Cpp check style fix
moisesmata Jun 19, 2025
6372c80
Fix: Add missing tearDownComponents cleanup for DataProducts dpBuffer…
moisesmata Jun 20, 2025
f414203
Delete old comments, test using same mallocator for all subtopologies
moisesmata Jun 20, 2025
be7896f
fix: Deallocated DataProducts BufferMgr
moisesmata Jun 20, 2025
485e847
Fix DataProducts subtopology memory cleanup
moisesmata Jun 20, 2025
ed3efd6
Fix: Dataproducts subtopology teardown order
moisesmata Jun 20, 2025
5f80673
Added tearDownComponents(state)
moisesmata Jun 20, 2025
4aa1833
Consolidate all cleanup to teardowncomponents
moisesmata Jun 20, 2025
5d60b98
Fix memory leaks: restore teardown phases
moisesmata Jun 20, 2025
29d4ff8
Removal of redundant teardowncomponents()
moisesmata Jun 20, 2025
db8639e
Revert "Removal of redundant teardowncomponents()"
moisesmata Jun 20, 2025
5752da5
Merge branch 'devel' into add-subtopologies
moisesmata Jun 20, 2025
440f25d
Fix formatting, remove commented out code
moisesmata Jun 20, 2025
b161d79
Swap hardcoded numbers to config constants in subtopologies
moisesmata Jun 23, 2025
d35a7f8
register_fprime_config() in config modules, isolated ComDriver into a…
moisesmata Jun 23, 2025
6b96fea
Added explicit CMake Module Names and Depends between Subtopologies a…
moisesmata Jun 23, 2025
6be5924
Merge branch 'devel' into add-subtopologies
moisesmata Jun 24, 2025
15d6a47
Merge branch 'nasa:devel' into add-subtopologies
moisesmata Jun 24, 2025
71dda8f
Fixed CCSDS case, more config constants
moisesmata Jun 24, 2025
adecade
Merge branch 'nasa:devel' into add-subtopologies
moisesmata Jun 25, 2025
de21d77
Added explicit depends for each subtopology config
moisesmata Jun 25, 2025
eea963d
added mallocator config, subtopology state structure
moisesmata Jun 26, 2025
909bba9
Merge branch 'devel' into add-subtopologies
moisesmata Jun 26, 2025
254c1af
Update subtopology config names for clarity, fixes #3571
moisesmata Jun 26, 2025
ce79ef9
Merge branch 'devel' into add-subtopologies
moisesmata Jun 26, 2025
d963509
Fix reference to dpBuffer config Constants
moisesmata Jun 26, 2025
e93c382
Merge branch 'add-subtopologies' of https://github.com/moisesmata/fpr…
moisesmata Jun 26, 2025
b794863
Merge branch 'devel' into add-subtopologies
moisesmata Jun 26, 2025
02d3ba4
Merge branch 'devel' into add-subtopologies
moisesmata Jun 26, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions .github/actions/spelling/expect.txt
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ CComponent
ccsds
ccsparc
CDH
CDHCORE
cerrno
CFDP
cff
Expand Down Expand Up @@ -148,7 +147,6 @@ DHTML
diafile
diles
dinkel
dnf
dnp
docbook
docset
Expand Down Expand Up @@ -211,6 +209,7 @@ ffff
Ffs
FILEDOWNLINK
FILEDOWNLINKCFG
FILEHANDLINGSUBTOPOLOGY
Copy link

Copilot AI Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the new guard identifiers DATAPRODUCTSSUBTOPOLOGY, COMFPRIMESUBTOPOLOGY, and COMCCSDSSUBTOPOLOGY to the spelling exceptions to avoid false positives.

Copilot uses AI. Check for mistakes.
FILEID
FILEOPENERROR
FILEWRITEERROR
Expand Down Expand Up @@ -240,8 +239,6 @@ gcgandhi
gcov
gdiplus
GENHUB
getfooter
getstatements
gettime
getty
ghprb
Expand Down Expand Up @@ -392,7 +389,6 @@ NACI
nasafprime
nbits
ncsl
netinet
newtio
nmsgs
NOBLOCK
Expand All @@ -407,8 +403,6 @@ NSHUFF
NSPACES
ntohs
objcopy
OCF
ODR
oflag
okidocki
OLDINCLUDEDIR
Expand Down Expand Up @@ -493,7 +487,6 @@ ptbool
ptf
pthread
ptrt
Pvn
qch
qhelpgenerator
QHG
Expand All @@ -515,7 +508,6 @@ rcvd
rdwr
Readback
Recvd
redhat
refspec
REFTOPOLOGY
REFTOPOLOGYDEFS
Expand All @@ -539,7 +531,6 @@ sats
SBF
SBINDIR
sbom
scid
scm
sdd
searchdata
Expand Down Expand Up @@ -620,7 +611,6 @@ TCPCLIENT
TCPHELPER
TCPSERVER
TCSANOW
Telecommand
telem
TELEMCHANIMPL
testerbase
Expand Down Expand Up @@ -669,9 +659,6 @@ useconds
usecs
valgrind
vbai
VCA
vcid
VCP
VFILE
VID
vla
Expand Down
1 change: 1 addition & 0 deletions RPI/Top/topology.fpp
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ module RPI {
fileUplink.bufferSendOut -> fprimeRouter.fileBufferReturnIn
}


}

}
2 changes: 1 addition & 1 deletion Ref/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ include("${CMAKE_CURRENT_LIST_DIR}/../cmake/FPrime.cmake")
# NOTE: register custom targets between these two lines
fprime_setup_included_code()
##
# Section 3: Components and Topology
# Section 3: Components and Topology and Subtopologies
#
# This section includes deployment specific directories. This allows use of non-
# core components in the topology, which is also added here.
Expand Down
1 change: 1 addition & 0 deletions Ref/Top/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
add_compile_options(
-Wno-shadow
)

set(SOURCE_FILES
"${CMAKE_CURRENT_LIST_DIR}/instances.fpp"
"${CMAKE_CURRENT_LIST_DIR}/topology.fpp"
Expand Down
132 changes: 68 additions & 64 deletions Ref/Top/RefPackets.fppi
Original file line number Diff line number Diff line change
@@ -1,39 +1,43 @@
telemetry packets RefPackets {

packet CDH id 1 group 1 {
CDHCore.cmdDisp.CommandsDispatched

#Ref.cmdDisp.CommandsDispatched

CdhCore.cmdDisp.CommandsDispatched

Check warning on line 7 in Ref/Top/RefPackets.fppi

View workflow job for this annotation

GitHub Actions / Check Spelling

`Cdh` is not a recognized word. (unrecognized-spelling)
Ref.rateGroup1Comp.RgMaxTime
Ref.rateGroup2Comp.RgMaxTime
Ref.rateGroup3Comp.RgMaxTime
Ref.cmdSeq.CS_LoadCommands
Ref.cmdSeq.CS_CancelCommands
Ref.cmdSeq.CS_CommandsExecuted
Ref.cmdSeq.CS_SequencesCompleted
Ref.fileUplink.FilesReceived
Ref.fileUplink.PacketsReceived
Ref.commsBufferManager.TotalBuffs
Ref.commsBufferManager.CurrBuffs
Ref.commsBufferManager.HiBuffs
Ref.fileDownlink.FilesSent
Ref.fileDownlink.PacketsSent
Ref.fileManager.CommandsExecuted
Ref.comQueue.comQueueDepth
Ref.comQueue.buffQueueDepth
#CDHCore.tlmSend.SendLevel
ComCcsds.cmdSeq.CS_LoadCommands
ComCcsds.cmdSeq.CS_CancelCommands
ComCcsds.cmdSeq.CS_CommandsExecuted
ComCcsds.cmdSeq.CS_SequencesCompleted
FileHandling.fileUplink.FilesReceived
FileHandling.fileUplink.PacketsReceived
ComCcsds.commsBufferManager.TotalBuffs
ComCcsds.commsBufferManager.CurrBuffs
ComCcsds.commsBufferManager.HiBuffs
FileHandling.fileDownlink.FilesSent
FileHandling.fileDownlink.PacketsSent
FileHandling.fileManager.CommandsExecuted
ComCcsds.comQueue.comQueueDepth
ComCcsds.comQueue.buffQueueDepth
# Ref.tlmSend.SendLevel
}

packet CDHErrors id 2 group 1 {
Ref.rateGroup1Comp.RgCycleSlips
Ref.rateGroup2Comp.RgCycleSlips
Ref.rateGroup3Comp.RgCycleSlips
Ref.cmdSeq.CS_Errors
Ref.fileUplink.Warnings
Ref.fileDownlink.Warnings
CDHCore.$health.PingLateWarnings
Ref.fileManager.Errors
Ref.commsBufferManager.NoBuffs
Ref.commsBufferManager.EmptyBuffs
Ref.fileManager.Errors
ComCcsds.cmdSeq.CS_Errors
FileHandling.fileUplink.Warnings
FileHandling.fileDownlink.Warnings
CdhCore.$health.PingLateWarnings
FileHandling.fileManager.Errors
ComCcsds.commsBufferManager.NoBuffs
ComCcsds.commsBufferManager.EmptyBuffs
FileHandling.fileManager.Errors

}

packet DriveTlm id 3 group 1 {
Expand Down Expand Up @@ -175,94 +179,94 @@
}

packet DataProducts id 21 group 3 {
Ref.dpCat.CatalogDps
Ref.dpCat.DpsSent
Ref.dpMgr.NumSuccessfulAllocations
Ref.dpMgr.NumFailedAllocations
Ref.dpMgr.NumDataProducts
Ref.dpMgr.NumBytes
Ref.dpWriter.NumBuffersReceived
Ref.dpWriter.NumBytesWritten
Ref.dpWriter.NumSuccessfulWrites
Ref.dpWriter.NumFailedWrites
Ref.dpWriter.NumErrors
Ref.dpBufferManager.TotalBuffs
Ref.dpBufferManager.CurrBuffs
Ref.dpBufferManager.HiBuffs
Ref.dpBufferManager.NoBuffs
Ref.dpBufferManager.EmptyBuffs
DataProducts.dpCat.CatalogDps
DataProducts.dpCat.DpsSent
DataProducts.dpMgr.NumSuccessfulAllocations
DataProducts.dpMgr.NumFailedAllocations
DataProducts.dpMgr.NumDataProducts
DataProducts.dpMgr.NumBytes
DataProducts.dpWriter.NumBuffersReceived
DataProducts.dpWriter.NumBytesWritten
DataProducts.dpWriter.NumSuccessfulWrites
DataProducts.dpWriter.NumFailedWrites
DataProducts.dpWriter.NumErrors
DataProducts.dpBufferManager.TotalBuffs
DataProducts.dpBufferManager.CurrBuffs
DataProducts.dpBufferManager.HiBuffs
DataProducts.dpBufferManager.NoBuffs
DataProducts.dpBufferManager.EmptyBuffs
}

packet Version1 id 22 group 2 {
CDHCore.version.FrameworkVersion
CDHCore.version.ProjectVersion
CdhCore.version.FrameworkVersion
CdhCore.version.ProjectVersion
}

packet Version_Library1 id 23 group 2 {
CDHCore.version.LibraryVersion01
CDHCore.version.LibraryVersion02
CdhCore.version.LibraryVersion01
CdhCore.version.LibraryVersion02
}

packet Version_Library2 id 24 group 2 {
CDHCore.version.LibraryVersion03
CDHCore.version.LibraryVersion04
CdhCore.version.LibraryVersion03
CdhCore.version.LibraryVersion04
}

packet Version_Library3 id 25 group 2 {
CDHCore.version.LibraryVersion05
CDHCore.version.LibraryVersion06
CdhCore.version.LibraryVersion05
CdhCore.version.LibraryVersion06
}

packet Version_Library4 id 26 group 2 {
CDHCore.version.LibraryVersion07
CDHCore.version.LibraryVersion08
CdhCore.version.LibraryVersion07
CdhCore.version.LibraryVersion08
}

packet Version_Library5 id 27 group 2 {
CDHCore.version.LibraryVersion09
CDHCore.version.LibraryVersion10
CdhCore.version.LibraryVersion09
CdhCore.version.LibraryVersion10
}

packet Version_Custom1 id 28 group 2 {
CDHCore.version.CustomVersion01
CdhCore.version.CustomVersion01
}

packet Version_Custom2 id 29 group 2 {
CDHCore.version.CustomVersion02
CdhCore.version.CustomVersion02
}

packet Version_Custom3 id 30 group 2 {
CDHCore.version.CustomVersion03
CdhCore.version.CustomVersion03
}

packet Version_Custom4 id 31 group 2 {
CDHCore.version.CustomVersion04
CdhCore.version.CustomVersion04
}

packet Version_Custom5 id 32 group 2 {
CDHCore.version.CustomVersion05
CdhCore.version.CustomVersion05
}

packet Version_Custom6 id 33 group 2 {
CDHCore.version.CustomVersion06
CdhCore.version.CustomVersion06
}

packet Version_Custom7 id 34 group 2 {
CDHCore.version.CustomVersion07
CdhCore.version.CustomVersion07
}

packet Version_Custom8 id 35 group 2 {
CDHCore.version.CustomVersion08
CdhCore.version.CustomVersion08
}

packet Version_Custom9 id 36 group 2 {
CDHCore.version.CustomVersion09
CdhCore.version.CustomVersion09
}

packet Version_Custom10 id 37 group 2 {
CDHCore.version.CustomVersion10
CdhCore.version.CustomVersion10
}

} omit {
CDHCore.cmdDisp.CommandErrors
}
CdhCore.cmdDisp.CommandErrors
}
Loading
Loading